Remove h/t/incremental/frame-focus-before-load.html from SlowTests

Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
NOTRY=true

Committed: https://crrev.com/57954f33c1620558ce3403ffdb49ba10b4a8d35d
Cr-Commit-Position: refs/heads/master@{#407053}

[kochi, 2016-07-21 06:17:53]

Description was changed from

==========
Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
==========

to

==========
Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
==========

[kochi, 2016-07-21 06:17:53]

kochi@chromium.org changed reviewers:
+ lukasza@chromium.org

[kochi, 2016-07-21 06:19:13]

lukasza@, is it okay to remove the entry?

[Łukasz Anforowicz, 2016-07-21 16:25:54]

On 2016/07/21 06:19:13, kochi wrote:
> lukasza@, is it okay to remove the entry?

lgtm

one note and a question (not blocking the CL):

- note: unfortunately CQ doesn't see a dependency between layout test exception
files (e.g. third_party/WebKit/LayoutTests/SlowTests) and webkit_tests step on
the trybot (i.e.
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...
from patchset #1 didn't run layout tests at all).  this is tracked by
https://crbug.com/583119.  otoh, I do see that recent site isolation FYI bots
did finish the test in 1.3 seconds.

- question: what is the threshold for marking the test as slow?  the default
timeout for non-debug builds is 6 seconds afair, so it seems to me that tests
running slower than 1 second are relatively likely to timeout from time to time
(even though there is no real hang - the test might run slower because of some
external, parallel activity on the bot).  What is the harm from keeping a test
on the Slow list (if it legitimately runs multiple iterations and so is expected
to take more than a second to execute)?

[kochi, 2016-07-22 01:33:24]

Description was changed from

==========
Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
==========

to

==========
Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
NOTRY=true
==========

[kochi, 2016-07-22 01:34:35]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2016-07-22 01:35:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kochi, 2016-07-22 01:51:34]

On 2016/07/21 16:25:54, Łukasz Anforowicz wrote:
> On 2016/07/21 06:19:13, kochi wrote:
> > lukasza@, is it okay to remove the entry?
> 
> lgtm
> 
> one note and a question (not blocking the CL):
> 
> - note: unfortunately CQ doesn't see a dependency between layout test
exception
> files (e.g. third_party/WebKit/LayoutTests/SlowTests) and webkit_tests step on
> the trybot (i.e.
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...
> from patchset #1 didn't run layout tests at all).  this is tracked by
> https://crbug.com/583119.  otoh, I do see that recent site isolation FYI bots
> did finish the test in 1.3 seconds.
> 
> - question: what is the threshold for marking the test as slow?  the default
> timeout for non-debug builds is 6 seconds afair, so it seems to me that tests
> running slower than 1 second are relatively likely to timeout from time to
time
> (even though there is no real hang - the test might run slower because of some
> external, parallel activity on the bot).  What is the harm from keeping a test
> on the Slow list (if it legitimately runs multiple iterations and so is
expected
> to take more than a second to execute)?

I think the reason SlotTests expectation exists is to motivate writing faster
tests
or making identifying tests that needs fix easier, generally speaking, faster
tests
reduces trybots cycle, development iteration etc.  As far as I know there is no
hard limit to put a test in the SlowTests expectation file, such as 1 second is
bad while 0.9 second is okay.

[commit-bot: I haz the power, 2016-07-22 03:57:27]

Description was changed from

==========
Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
NOTRY=true
==========

to

==========
Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
NOTRY=true
==========

[commit-bot: I haz the power, 2016-07-22 03:57:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 03:59:24]

Description was changed from

==========
Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
NOTRY=true
==========

to

==========
Remove h/t/incremental/frame-focus-before-load.html from SlowTests

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
NOTRY=true

Committed: https://crrev.com/57954f33c1620558ce3403ffdb49ba10b4a8d35d
Cr-Commit-Position: refs/heads/master@{#407053}
==========

[commit-bot: I haz the power, 2016-07-22 03:59:25]

Patchset 1 (id:??) landed as
https://crrev.com/57954f33c1620558ce3403ffdb49ba10b4a8d35d
Cr-Commit-Position: refs/heads/master@{#407053}