runtime/observatory/tests/service/test_helper.dart - Issue 2172513003: Rate limit devfs writes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 2172513003: Rate limit devfs writes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/test_helper.dart

diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart

index 28c31ade66c40bada310e2d91fe014b649564b04..df140c525009ca782ffa65b57fbef5b261fd61fe 100644

--- a/runtime/observatory/tests/service/test_helper.dart

+++ b/runtime/observatory/tests/service/test_helper.dart

@@ -102,10 +102,6 @@ class _ServiceTesteeLauncher {

assert(trace_service != null);

assert(trace_compiler != null);

- // TODO(turnidge): I have temporarily turned on service tracing for

- // all tests to help diagnose flaky tests.

- trace_service = true;

if (_shouldLaunchSkyShell()) {

return _spawnSkyProcess(pause_on_start,

pause_on_exit,

« no previous file with comments | « runtime/bin/vmservice/vmservice_io.dart ('k') | no next file » | no next file with comments »