Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4310)

Unified Diff: chrome/browser/resources/offline_pages/offline_internals.js

Issue 2172443004: [Offline Pages] Add network status, save request textbox, and offline url link to offline internals… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update SavePageRequest call after rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/offline_pages/offline_internals.js
diff --git a/chrome/browser/resources/offline_pages/offline_internals.js b/chrome/browser/resources/offline_pages/offline_internals.js
index 3bfde97d874884aab6a7a9f11c9332632cafc994..4112e45ad206c1b2f60fec29ddbf9fd6553bb10a 100644
--- a/chrome/browser/resources/offline_pages/offline_internals.js
+++ b/chrome/browser/resources/offline_pages/offline_internals.js
@@ -37,7 +37,10 @@ cr.define('offlineInternals', function() {
row.appendChild(checkboxCell);
var cell = document.createElement('td');
- cell.textContent = pages[i].onlineUrl;
+ var link = document.createElement('a');
+ link.setAttribute('href', pages[i].filePath);
+ link.textContent = pages[i].onlineUrl;
+ cell.appendChild(link);
row.appendChild(cell);
cell = document.createElement('td');
@@ -106,6 +109,9 @@ cr.define('offlineInternals', function() {
function refreshAll() {
browserProxy_.getStoredPages().then(fillStoredPages);
browserProxy_.getRequestQueue().then(fillRequestQueue);
+ browserProxy_.getNetworkStatus().then(function(networkStatus) {
+ $('current-status').textContent = networkStatus;
+ });
refreshLog();
}
@@ -173,19 +179,47 @@ cr.define('offlineInternals', function() {
}
function initialize() {
+ /**
+ * @param {!boolean} enabled Whether to enable Logging.
+ */
+ function togglePageModelLog(enabled) {
+ browserProxy_.setRecordPageModel(enabled);
+ $('model-status').textContent = enabled ? 'On' : 'Off';
+ }
+
+ /**
+ * @param {!boolean} enabled Whether to enable Logging.
+ */
+ function toggleRequestQueueLog(enabled) {
+ browserProxy_.setRecordRequestQueue(enabled);
+ $('request-status').textContent = enabled ? 'On' : 'Off';
+ }
+
$('clear-all').onclick = deleteAllPages;
$('clear-selected').onclick = deleteSelectedPages;
$('refresh').onclick = refreshAll;
$('download').onclick = download;
- $('log-model-on').onclick =
- browserProxy_.setRecordPageModel.bind(browserProxy_, true);
- $('log-model-off').onclick =
- browserProxy_.setRecordPageModel.bind(browserProxy_, false);
- $('log-request-on').onclick =
- browserProxy_.setRecordRequestQueue.bind(browserProxy_, true);
- $('log-request-off').onclick =
- browserProxy_.setRecordRequestQueue.bind(browserProxy_, false);
+ $('log-model-on').onclick = togglePageModelLog.bind(this, true);
+ $('log-model-off').onclick = togglePageModelLog.bind(this, false);
+ $('log-request-on').onclick = toggleRequestQueueLog.bind(this, true);
+ $('log-request-off').onclick = toggleRequestQueueLog.bind(this, false);
$('refresh-logs').onclick = refreshLog;
+ $('add-to-queue').onclick = function() {
+ var saveUrl = $('url').value;
+ browserProxy_.addToRequestQueue(saveUrl)
+ .then(function(state) {
+ if (state) {
+ $('save-url-state').textContent =
+ saveUrl + ' has been added to queue.';
+ $('url').value = '';
+ browserProxy_.getRequestQueue().then(fillRequestQueue);
+ } else {
+ $('save-url-state').textContent =
+ saveUrl + ' failed to be added to queue.';
+ }
+ });
+ };
+
refreshAll();
}

Powered by Google App Engine
This is Rietveld 408576698