Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js

Issue 2172443004: [Offline Pages] Add network status, save request textbox, and offline url link to offline internals… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
diff --git a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
index f3312fbcda4a94497918104ef01f57a55d98d9f7..7061b95942bd39361e6791bcd1ba0303f3d72e0d 100644
--- a/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
+++ b/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
@@ -95,6 +95,20 @@ cr.define('offlineInternals', function() {
* is retrieved.
*/
getLoggingState: function() {},
+
+ /**
+ * Adds the given url to the background loader queue.
+ * @param {string} url Url of the page to load later.
+ * @return {!Promise<boolean>} A promise firing after added to queue.
dpapad 2016/07/21 18:57:25 What does the boolean indicate? Please explain in
chili 2016/07/21 23:57:20 Done.
+ */
+ addToRequestQueue: function(url) {},
+
+ /**
+ * Gets the current network status in string form.
+ * @return {!Promise<!string>} A promise firing when the network status
dpapad 2016/07/21 18:57:25 "!string" is same as "string", since primitive typ
chili 2016/07/21 23:57:20 Done.
+ * is retrieved.
+ */
+ getNetworkStatus: function() {},
};
/**
@@ -143,7 +157,17 @@ cr.define('offlineInternals', function() {
/** @override */
getLoggingState: function() {
return cr.sendWithPromise('getLoggingState');
- }
+ },
+
+ /** @override */
+ addToRequestQueue: function(url) {
+ return cr.sendWithPromise('addToRequestQueue', url);
+ },
+
+ /** @override */
+ getNetworkStatus: function() {
+ return cr.sendWithPromise('getNetworkStatus');
+ },
};
return {

Powered by Google App Engine
This is Rietveld 408576698