Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2172423002: Simplify WebrtcDataStreamAdapter (Closed)

Created:
4 years, 5 months ago by Sergey Ulanov
Modified:
4 years, 5 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify WebrtcDataStreamAdapter Previously WebrtcDataStreamAdapter acted as a factory of MessagePipe adapters, now it works as an adapter itself. It gets webrtc::DataChannelInterface in the constructor and the WebrtcTransport is responsible for creation of the data channels themselves. Committed: https://crrev.com/f4fd0818ba6c902dd6dedffecda8161f76e8d9e7 Cr-Commit-Position: refs/heads/master@{#407543}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -90 lines) Patch
M remoting/protocol/webrtc_data_stream_adapter.h View 1 chunk +26 lines, -18 lines 2 comments Download
M remoting/protocol/webrtc_data_stream_adapter.cc View 4 chunks +7 lines, -64 lines 0 comments Download
M remoting/protocol/webrtc_transport.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_transport.cc View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sergey Ulanov
4 years, 5 months ago (2016-07-22 22:48:01 UTC) #2
Jamie
lgtm https://codereview.chromium.org/2172423002/diff/1/remoting/protocol/webrtc_data_stream_adapter.h File remoting/protocol/webrtc_data_stream_adapter.h (right): https://codereview.chromium.org/2172423002/diff/1/remoting/protocol/webrtc_data_stream_adapter.h#newcode40 remoting/protocol/webrtc_data_stream_adapter.h:40: void OnMessage(const webrtc::DataBuffer& buffer) override; These are public ...
4 years, 5 months ago (2016-07-25 18:25:59 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/2172423002/diff/1/remoting/protocol/webrtc_data_stream_adapter.h File remoting/protocol/webrtc_data_stream_adapter.h (right): https://codereview.chromium.org/2172423002/diff/1/remoting/protocol/webrtc_data_stream_adapter.h#newcode40 remoting/protocol/webrtc_data_stream_adapter.h:40: void OnMessage(const webrtc::DataBuffer& buffer) override; On 2016/07/25 18:25:59, Jamie ...
4 years, 5 months ago (2016-07-25 18:48:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172423002/1
4 years, 5 months ago (2016-07-25 18:48:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 19:27:45 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 19:30:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4fd0818ba6c902dd6dedffecda8161f76e8d9e7
Cr-Commit-Position: refs/heads/master@{#407543}

Powered by Google App Engine
This is Rietveld 408576698