rAc: try really hard not to ellipsize addresses

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 1058 matching lines @@
 
 void AutofillDialogControllerImpl::ShowEditUiIfBadSuggestion(
     DialogSection section) {
   // |CreateWrapper()| returns an empty wrapper if |IsEditingExistingData()|, so
   // get the wrapper before this potentially happens below.
   scoped_ptr<DataModelWrapper> wrapper = CreateWrapper(section);
 
   // If the chosen item in |model| yields an empty suggestion text, it is
   // invalid. In this case, show the edit UI and highlight invalid fields.
   SuggestionsMenuModel* model = SuggestionsMenuModelForSection(section);
+  string16 unused, unused2;
   if (IsASuggestionItemKey(model->GetItemKeyForCheckedItem()) &&
-      SuggestionTextForSection(section).empty()) {
+      !SuggestionTextForSection(section, &unused, &unused2)) {
     SetEditingExistingData(section, true);
   }
 
   DetailInputs* inputs = MutableRequestedFieldsForSection(section);
   if (wrapper && IsEditingExistingData(section))
     wrapper->FillInputs(inputs);
 
   for (DetailInputs::iterator it = inputs->begin(); it != inputs->end(); ++it) {
     it->editable = InputIsEditable(*it, section);
   }
@@ skipping 203 matching lines @@
     case SECTION_SHIPPING:
       return l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_SECTION_SHIPPING);
     default:
       NOTREACHED();
       return string16();
   }
 }
 
 SuggestionState AutofillDialogControllerImpl::SuggestionStateForSection(
     DialogSection section) {
-  return SuggestionState(SuggestionTextForSection(section),
-                         SuggestionTextStyleForSection(section),
+  string16 vertically_compact, horizontally_compact;
+  bool show_suggestion = SuggestionTextForSection(section,
+                                                  &vertically_compact,
+                                                  &horizontally_compact);
+  return SuggestionState(show_suggestion,
+                         vertically_compact,
+                         horizontally_compact,
                          SuggestionIconForSection(section),
                          ExtraSuggestionTextForSection(section),
                          ExtraSuggestionIconForSection(section));
 }
 
-string16 AutofillDialogControllerImpl::SuggestionTextForSection(
-    DialogSection section) {
-  string16 action_text = RequiredActionTextForSection(section);
-  if (!action_text.empty())
-    return action_text;
+bool AutofillDialogControllerImpl::SuggestionTextForSection(
+    DialogSection section,
+    base::string16* vertically_compact,
+    base::string16* horizontally_compact) {
+  base::string16 action_text = RequiredActionTextForSection(section);
+  if (!action_text.empty()) {
+    *vertically_compact = *horizontally_compact = action_text;
+    return true;
+  }
 
   // When the user has clicked 'edit' or a suggestion is somehow invalid (e.g. a
   // user selects a credit card that has expired), don't show a suggestion (even
   // though there is a profile selected in the model).
   if (IsEditingExistingData(section))
-    return string16();
+    return false;
 
   SuggestionsMenuModel* model = SuggestionsMenuModelForSection(section);
   std::string item_key = model->GetItemKeyForCheckedItem();
   if (item_key == kSameAsBillingKey) {
-    return l10n_util::GetStringUTF16(
+    *vertically_compact = *horizontally_compact = l10n_util::GetStringUTF16(
         IDS_AUTOFILL_DIALOG_USING_BILLING_FOR_SHIPPING);
+    return true;
   }
 
   if (!IsASuggestionItemKey(item_key))
-    return string16();
+    return false;
 
-  if (section == SECTION_EMAIL)
-    return model->GetLabelAt(model->checked_item());
+  if (section == SECTION_EMAIL) {
+    *vertically_compact = *horizontally_compact =
+        model->GetLabelAt(model->checked_item());
+    return true;
+  }
 
   scoped_ptr<DataModelWrapper> wrapper = CreateWrapper(section);
-  return wrapper->GetDisplayText();
-}
-
-gfx::Font::FontStyle
-    AutofillDialogControllerImpl::SuggestionTextStyleForSection(
-        DialogSection section) const {
-  const SuggestionsMenuModel* model = SuggestionsMenuModelForSection(section);
-  if (model->GetItemKeyForCheckedItem() == kSameAsBillingKey)
-    return gfx::Font::ITALIC;
-
-  return gfx::Font::NORMAL;
+  return wrapper->GetDisplayText(vertically_compact, horizontally_compact);
 }
 
 string16 AutofillDialogControllerImpl::RequiredActionTextForSection(
     DialogSection section) const {
   if (section == SECTION_CC_BILLING && IsSubmitPausedOn(wallet::VERIFY_CVV)) {
     const wallet::WalletItems::MaskedInstrument* current_instrument =
         wallet_items_->GetInstrumentById(active_instrument_id_);
     if (current_instrument)
       return current_instrument->TypeAndLastFourDigits();
 
@@ skipping 2110 matching lines @@
     view_->GetUserInput(SECTION_CC_BILLING, &output);
     CreditCard card;
     GetBillingInfoFromOutputs(output, &card, NULL, NULL);
     backing_last_four = card.TypeAndLastFourDigits();
   }
   AutofillCreditCardBubbleController::ShowGeneratedCardUI(
       web_contents(), backing_last_four, full_wallet_->TypeAndLastFourDigits());
 }
 
 }  // namespace autofill