Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2172393002: Cleaning up some code in UINQEService (Closed)

Created:
4 years, 5 months ago by RyanSturm
Modified:
4 years, 5 months ago
Reviewers:
tbansal1
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleaning up some code in UINQEService This should allow some unittests (specifically offline pages related unittests) to create the UINQEService despite not being a browser process with no IOThread. BUG= Committed: https://crrev.com/524692f9fe69f856187801d3954fff29f69ec47f Cr-Commit-Position: refs/heads/master@{#407274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/browser/net/nqe/ui_network_quality_estimator_service.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/net/nqe/ui_network_quality_estimator_service.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/net/nqe/ui_network_quality_estimator_service_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
RyanSturm
tbansal: PTAL at *, small change, thanks
4 years, 5 months ago (2016-07-22 21:34:02 UTC) #6
tbansal1
lgtm
4 years, 5 months ago (2016-07-22 21:37:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172393002/1
4 years, 5 months ago (2016-07-22 21:46:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 21:51:36 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 21:54:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/524692f9fe69f856187801d3954fff29f69ec47f
Cr-Commit-Position: refs/heads/master@{#407274}

Powered by Google App Engine
This is Rietveld 408576698