Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2172373002: [Sync] Don't start up sync when FirstSetupCompleted is false and no setup in progress (Closed)

Created:
4 years, 5 months ago by Nicolas Zea
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Sync] Don't start up sync when FirstSetupCompleted is false and no setup in progress Instead of starting up the backend, we now don't even start it up if the first setup completed flag is false, unless a setup is in progress. On auto start platforms, first setup completed is manually set to true as part of init. BUG=624915 Review-Url: https://codereview.chromium.org/2159453002 Cr-Commit-Position: refs/heads/master@{#405950} (cherry picked from commit d1de1f77e44072018f41b1f54ffca27a7069edb4) Committed: https://chromium.googlesource.com/chromium/src/+/fc73af1efc8567989b54e27b53977bd92937d0de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -28 lines) Patch
M components/browser_sync/browser/profile_sync_service.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_startup_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync_driver/startup_controller.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/sync_driver/startup_controller.cc View 3 chunks +17 lines, -6 lines 0 comments Download
M components/sync_driver/startup_controller_unittest.cc View 2 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Nicolas Zea
4 years, 5 months ago (2016-07-22 19:27:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc73af1efc8567989b54e27b53977bd92937d0de.

Powered by Google App Engine
This is Rietveld 408576698