Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 2172363002: Created min size for print preview dialog and modified to allow the Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac compile error. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_modal/web_contents_modal_dialog_manager.h
diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h
index 9d964d1c4edc46fdf58cac519245bf22759850fc..51558ce1072a3108f92ac438fdeba5bff42e2934 100644
--- a/components/web_modal/web_contents_modal_dialog_manager.h
+++ b/components/web_modal/web_contents_modal_dialog_manager.h
@@ -7,6 +7,7 @@
#include <deque>
#include <memory>
+#include <set>
#include "base/macros.h"
#include "build/build_config.h"
@@ -54,6 +55,8 @@ class WebContentsModalDialogManager
// SingleWebContentsDialogManagerDelegate:
content::WebContents* GetWebContents() const override;
void WillClose(gfx::NativeWindow dialog) override;
+ bool IsNonClipped(gfx::NativeWindow dialog) const override;
+ void AddNonClippedDialog(gfx::NativeWindow dialog) override;
Mike Wittman 2016/08/19 14:57:29 why do we need this function?
rbpotter 2016/08/19 16:59:42 I added it in since ShowModalDialog moved to show_
Mike Wittman 2016/08/19 17:51:42 I see. This approach is kind of odd because at the
// For testing.
class TestApi {
@@ -115,6 +118,9 @@ class WebContentsModalDialogManager
// All active dialogs.
WebContentsModalDialogList child_dialogs_;
+ // All non clipped active dialogs
+ std::set<gfx::NativeWindow> nonclipped_child_dialogs_;
+
// True while closing the dialogs on WebContents close.
bool closing_all_dialogs_;

Powered by Google App Engine
This is Rietveld 408576698