Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/constrained_window/constrained_window_views.h

Issue 2172363002: Created min size for print preview dialog and modified to allow the Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac compile error. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/constrained_window/constrained_window_views.h
diff --git a/components/constrained_window/constrained_window_views.h b/components/constrained_window/constrained_window_views.h
index e8c057f1561e628f003021e66f8a8c941dbbd6b3..8857b2d3ea20eeb93b490ac00d4abbda82168a4b 100644
--- a/components/constrained_window/constrained_window_views.h
+++ b/components/constrained_window/constrained_window_views.h
@@ -47,11 +47,28 @@ void UpdateWidgetModalDialogPosition(
void ShowModalDialog(gfx::NativeWindow dialog,
content::WebContents* web_contents);
+// Shows the dialog with a new SingleWebContentsDialogManager in a non clipped
+// display (not confined to the bounds of the parent window) if this is
+// supported by the platform (currently Chrome OS and Mac only). The dialog will
+// notify via WillClose() when it is being destroyed.
+void ShowNonClippedModalDialog(gfx::NativeWindow dialog,
+ content::WebContents* web_contents);
+
// Calls CreateWebModalDialogViews, shows the dialog, and returns its widget.
views::Widget* ShowWebModalDialogViews(
views::WidgetDelegate* dialog,
content::WebContents* initiator_web_contents);
+// Calls CreateWebModalDialogViews, shows the dialog as a non-clipped dialog
+// (bounds not constrained by the parent window) and returns its widget. For
+// platforms that do not support unclipped dialogs and for Mac, which has
+// nonclipped dialogs by default, this has the same behavior as
Lei Zhang 2016/08/19 03:28:47 non-clipped
rbpotter 2016/08/19 16:59:42 Done.
+// ShowWebModalDialogViews. Currently, unclipped dialogs are only supported on
+// Chrome OS and Mac (Mac dialogs are always non clipped).
+views::Widget* ShowNonClippedWebModalDialogViews(
+ views::WidgetDelegate* dialog,
+ content::WebContents* initiator_web_contents);
+
// Create a widget for |dialog| that is modal to |web_contents|.
// The modal type of |dialog->GetModalType()| must be ui::MODAL_TYPE_CHILD.
views::Widget* CreateWebModalDialogViews(views::WidgetDelegate* dialog,

Powered by Google App Engine
This is Rietveld 408576698