Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_ui.h

Issue 2172363002: Created min size for print preview dialog and modified to allow the Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Track independent bounds as native window property not member of widget class Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/constrained_web_dialog_ui.h
diff --git a/chrome/browser/ui/webui/constrained_web_dialog_ui.h b/chrome/browser/ui/webui/constrained_web_dialog_ui.h
index 39cc74bca412488132b8ee87f954d241ec03ef6b..ae4b876c2999f20f76bc7d04610ee048cd8134ce 100644
--- a/chrome/browser/ui/webui/constrained_web_dialog_ui.h
+++ b/chrome/browser/ui/webui/constrained_web_dialog_ui.h
@@ -91,7 +91,8 @@ class ConstrainedWebDialogUI : public content::WebUIController {
// Create and show a constrained HTML dialog. The actual object that gets
// created is a ConstrainedWebDialogDelegate, which later triggers construction
-// of a ConstrainedWebDialogUI object.
+// of a ConstrainedWebDialogUI object. The returned object deletes itself when
+// the dialog closes.
// |browser_context| is used to construct the constrained HTML dialog's
// WebContents.
// |delegate| controls the behavior of the dialog.
@@ -101,9 +102,25 @@ ConstrainedWebDialogDelegate* ShowConstrainedWebDialog(
ui::WebDialogDelegate* delegate,
content::WebContents* overshadowed);
+// Create and show a constrained HTML dialog that, for ChromeOS, is not bound
+// to the limits of the parent window. For all other operating systems, which
+// do not support child windows that are not clipped to the parent window,
+// the function has the same behavior as ShowConstrainedWebDialog. The actual
+// object that gets created is a ConstrainedWebDialogDelegate, which later
+// triggers construction of a ConstrainedWebDialogUI object. The returned
+// object deletes itself when the dialog closes.
+// |browser_context| is used to construct the constrained HTML dialog's
+// WebContents.
+// |delegate| controls the behavior of the dialog.
+// |overshadowed| is the tab being overshadowed by the dialog.
+ConstrainedWebDialogDelegate* ShowTopLevelConstrainedWebDialog(
+ content::BrowserContext* browser_context,
+ ui::WebDialogDelegate* delegate,
+ content::WebContents* web_contents);
+
// Create and show a constrained HTML dialog with auto-resize enabled. The
// dialog is shown automatically after document load has completed to avoid UI
-// jankiness.
+// jankiness. The returned object deletes itself when the dialog closes.
// |browser_context| is used to construct the dialog's WebContents.
// |delegate| controls the behavior of the dialog.
// |overshadowed| is the tab being overshadowed by the dialog.

Powered by Google App Engine
This is Rietveld 408576698