chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm - Issue 2172363002: Created min size for print preview dialog and modified to allow the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm

Issue 2172363002: Created min size for print preview dialog and modified to allow the Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Track independent bounds as native window property not member of widget class Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/create_native_web_modal_manager_cocoa.mm ('k') | chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc » ('j') | components/constrained_window/constrained_window_views.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm b/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm

index 54f722fa391ef2952c66641fc955c66f028392e7..f9b27dcc0c91b96254da43d9050e318b399cf40f 100644

--- a/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm

+++ b/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm

@@ -49,7 +49,7 @@ class WebContentsModalDialogManagerViewsMacTest : public InProcessBrowserTest,

widget->AddObserver(this);

web_modal::WebContentsModalDialogManager* manager =

web_modal::WebContentsModalDialogManager::FromWebContents(web_contents);

- manager->ShowModalDialog(widget->GetNativeWindow());

+ manager->ShowModalDialog(widget->GetNativeWindow(), NULL, NULL);

return widget;

}