ash/wm/window_modality_controller_unittest.cc - Issue 2172363002: Created min size for print preview dialog and modified to allow the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/window_modality_controller_unittest.cc

Issue 2172363002: Created min size for print preview dialog and modified to allow the Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Track independent bounds as native window property not member of widget class Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/resize_handle_window_targeter.cc ('k') | chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc » ('j') | components/constrained_window/constrained_window_views.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/window_modality_controller_unittest.cc

diff --git a/ash/wm/window_modality_controller_unittest.cc b/ash/wm/window_modality_controller_unittest.cc

index e07be1b6a14601d9924011f3041c470cd16dd7a3..30b88fac300d4e0ff123f335dc5a4d90013988a8 100644

--- a/ash/wm/window_modality_controller_unittest.cc

+++ b/ash/wm/window_modality_controller_unittest.cc

@@ -337,7 +337,7 @@ TEST_F(WindowModalityControllerTest, ReleaseCapture) {

std::unique_ptr<aura::Window> w3(

CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));

w3->SetProperty(aura::client::kModalKey, ui::MODAL_TYPE_CHILD);

- ::wm::SetModalParent(w3.get(), w1.get());

+ ::wm::SetModalParent(w3.get(), w1.get(), NULL, NULL);

// w1's capture should be released when w3 becomes visible.

w3->Hide();

@@ -632,7 +632,7 @@ TEST_F(WindowModalityControllerTest, ChildModalAncestor) {

std::unique_ptr<aura::Window> w4(

CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));

w4->SetProperty(aura::client::kModalKey, ui::MODAL_TYPE_CHILD);

- ::wm::SetModalParent(w4.get(), w2.get());

+ ::wm::SetModalParent(w4.get(), w2.get(), NULL, NULL);

::wm::AddTransientChild(w1.get(), w4.get());

wm::ActivateWindow(w1.get());