Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7786)

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_ui.h

Issue 2172363002: Created min size for print preview dialog and modified to allow the Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge ConstrainedWebDialog functions Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/constrained_web_dialog_ui.h
diff --git a/chrome/browser/ui/webui/constrained_web_dialog_ui.h b/chrome/browser/ui/webui/constrained_web_dialog_ui.h
index 79a152c1a5a0848f96ecf7368f9495d021c057cd..8b0ed13d29731f1acfca05ec74baa4cbdc69d63d 100644
--- a/chrome/browser/ui/webui/constrained_web_dialog_ui.h
+++ b/chrome/browser/ui/webui/constrained_web_dialog_ui.h
@@ -99,6 +99,32 @@ ConstrainedWebDialogDelegate* ShowConstrainedWebDialog(
ui::WebDialogDelegate* delegate,
content::WebContents* overshadowed);
+// Create and show a constrained HTML dialog that is a peer rather than a child
+// of the original |web_contents| window. The dialog is top level but does not
+// prevent access to the original |web_contents| and on some platforms
+// (ChromeOS) can extend outside of the original parent window. The actual
+// object that gets created is a ConstrainedWebDialogDelegate, which later
+// triggers construction of a ConstrainedWebDialogUI object. The returned
+// object deletes itself when the dialog closes.
+// |browser_context| is used to construct the constrained HTML dialog's
+// WebContents.
+// |delegate| controls the behavior of the dialog.
+// |web_contents| is the tab being covered by the dialog.
+/*ConstrainedWebDialogDelegate* ShowTopLevelConstrainedWebDialog(
+ content::BrowserContext* browser_context,
+ ui::WebDialogDelegate* delegate,
+ content::WebContents* web_contents);*/
+
+// Like ShowTopLevelConstrainedWebDialog, but uses |dialog_host_window| as the
+// host window for the dialog rather than the modal dialog host view from the
+// top level window of web_contents. Used for unit test where GetRootView() and
+// GetHostView() may not work as expected.
+ConstrainedWebDialogDelegate* ShowTopLevelConstrainedWebDialogInWindow(
+ content::BrowserContext* browser_context,
+ ui::WebDialogDelegate* delegate,
+ content::WebContents* web_contents,
+ gfx::NativeView dialog_host_window);
+
// Create and show a constrained HTML dialog with auto-resize enabled. The
// dialog is shown automatically after document load has completed to avoid UI
// jankiness.
« no previous file with comments | « chrome/browser/ui/webui/certificate_viewer_webui.cc ('k') | chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698