Created min size for print preview dialog and modified to allow the

chrome/browser/printing/print_preview_dialog_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_preview_dialog_controller.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 60 matching lines @@
 };
 
 PrintPreviewDialogDelegate::PrintPreviewDialogDelegate(WebContents* initiator)
     : initiator_(initiator) {
 }
 
 PrintPreviewDialogDelegate::~PrintPreviewDialogDelegate() {
 }
 
 ui::ModalType PrintPreviewDialogDelegate::GetDialogModalType() const {
-  // Not used, returning dummy value.
-  NOTREACHED();
-  return ui::MODAL_TYPE_WINDOW;
+  return ui::MODAL_TYPE_CHILD;
 }
 
 base::string16 PrintPreviewDialogDelegate::GetDialogTitle() const {
   // Only used on Windows? UI folks prefer no title.
   return base::string16();
 }
 
 GURL PrintPreviewDialogDelegate::GetDialogContentURL() const {
   return GURL(chrome::kChromeUIPrintURL);
 }
 
 void PrintPreviewDialogDelegate::GetWebUIMessageHandlers(
     std::vector<WebUIMessageHandler*>* /* handlers */) const {
   // PrintPreviewUI adds its own message handlers.
 }
 
 void PrintPreviewDialogDelegate::GetDialogSize(gfx::Size* size) const {
   DCHECK(size);
+  const int kBorder = 25;
+  // Gives ChromeOS dialogs the requested minimum sizei of 438x455 without

[Lei Zhang, 2016/08/19 03:28:46]

s/sizei/size/

[rbpotter, 2016/08/19 16:59:42]

Done.

+  // changing the existing behavior on Mac OSX. For all other platforms, the min
+  // size is later overridden by the size of the parent window.
+#if defined(OS_MACOSX)
   const gfx::Size kMinDialogSize(800, 480);
-  const int kBorder = 25;
+#else
+  const gfx::Size kMinDialogSize(438, 455);
+#endif
   *size = kMinDialogSize;
 
   web_modal::WebContentsModalDialogHost* host = nullptr;
   content::WebContents* outermost_web_contents =
       guest_view::GuestViewBase::GetTopLevelWebContents(initiator_);
   Browser* browser = chrome::FindBrowserWithWebContents(outermost_web_contents);
   if (browser)
     host = browser->window()->GetWebContentsModalDialogHost();
 
   if (host)
     size->SetToMax(host->GetMaximumDialogSize());
   else
     size->SetToMax(outermost_web_contents->GetContainerBounds().size());
+#if defined(OS_MACOSX)
   size->Enlarge(-2 * kBorder, -kBorder);
+#else
+  int shrink_width =
+      std::max(-size->width() + kMinDialogSize.width(), -2 * kBorder);

[Lei Zhang, 2016/08/19 03:28:46]

If you stick with |shrink_width|, do kMinDialogSize.width() - size->width()

[rbpotter, 2016/08/19 16:59:42]

Done.

+  int shrink_height =
+      std::max(-size->height() + kMinDialogSize.height(), -kBorder);
+  size->Enlarge(shrink_width, shrink_height);
+#endif
 
 #if defined(OS_MACOSX)
   // Limit the maximum size on MacOS X.
   // http://crbug.com/105815
   const gfx::Size kMaxDialogSize(1000, 660);
   size->SetToMin(kMaxDialogSize);
 #endif
 }
 
 std::string PrintPreviewDialogDelegate::GetDialogArgs() const {
@@ skipping 234 matching lines @@
 
   RemoveInitiator(contents);
 }
 
 WebContents* PrintPreviewDialogController::CreatePrintPreviewDialog(
     WebContents* initiator) {
   base::AutoReset<bool> auto_reset(&is_creating_print_preview_dialog_, true);
 
   // The dialog delegates are deleted when the dialog is closed.
   ConstrainedWebDialogDelegate* web_dialog_delegate =
-      ShowConstrainedWebDialog(initiator->GetBrowserContext(),
-                               new PrintPreviewDialogDelegate(initiator),
-                               initiator);
+      ShowNonClippedConstrainedWebDialog(
+          initiator->GetBrowserContext(),
+          new PrintPreviewDialogDelegate(initiator), initiator);
 
   WebContents* preview_dialog = web_dialog_delegate->GetWebContents();
 
   // Clear the zoom level for the print preview dialog so it isn't affected by
   // the default zoom level. This also controls the zoom level of the OOP PDF
   // extension when iframed by the print preview dialog.
   GURL print_url(chrome::kChromeUIPrintURL);
   content::HostZoomMap::Get(preview_dialog->GetSiteInstance())
       ->SetZoomLevelForHostAndScheme(print_url.scheme(), print_url.host(), 0);
   PrintViewManager::CreateForWebContents(preview_dialog);
@@ skipping 86 matching lines @@
   if (initiator) {
     RemoveObservers(initiator);
     PrintViewManager::FromWebContents(initiator)->PrintPreviewDone();
   }
 
   preview_dialog_map_.erase(preview_dialog);
   RemoveObservers(preview_dialog);
 }
 
 }  // namespace printing