Created min size for print preview dialog and modified to allow the

chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h"
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/webui/chrome_web_contents_handler.h"
 #include "components/constrained_window/constrained_window_views.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/views/controls/webview/unhandled_keyboard_event_handler.h"
 #include "ui/views/controls/webview/webview.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/window/dialog_delegate.h"
 #include "ui/web_dialogs/web_dialog_delegate.h"
 #include "ui/web_dialogs/web_dialog_ui.h"
 
+#if defined(OS_WIN)
+#include "ui/base/win/shell.h"
+#endif
+
 namespace {
 
 // WebContentsObserver that tracks the lifetime of the WebContents to avoid
 // potential use after destruction.
 class InitiatorWebContentsObserver
     : public content::WebContentsObserver {
-  public:
-   explicit InitiatorWebContentsObserver(content::WebContents* web_contents)
-      : content::WebContentsObserver(web_contents) {
-   }
+ public:
+  explicit InitiatorWebContentsObserver(content::WebContents* web_contents)
+      : content::WebContentsObserver(web_contents) {}
 
-  private:
-    DISALLOW_COPY_AND_ASSIGN(InitiatorWebContentsObserver);
+ private:
+  DISALLOW_COPY_AND_ASSIGN(InitiatorWebContentsObserver);
 };
 
 class WebDialogWebContentsDelegateViews
     : public ui::WebDialogWebContentsDelegate {
  public:
   WebDialogWebContentsDelegateViews(content::BrowserContext* browser_context,
                                     InitiatorWebContentsObserver* observer,
                                     views::WebView* web_view)
       : ui::WebDialogWebContentsDelegate(browser_context,
                                          new ChromeWebContentsHandler()),
@@ skipping 88 matching lines @@
 class ConstrainedWebDialogDelegateViewViews
     : public views::WebView,
       public ConstrainedWebDialogDelegate,
       public views::WidgetDelegate {
  public:
   ConstrainedWebDialogDelegateViewViews(
       content::BrowserContext* browser_context,
       ui::WebDialogDelegate* delegate,
       content::WebContents* web_contents,
       const gfx::Size& min_size,
-      const gfx::Size& max_size)
+      const gfx::Size& max_size,
+      bool is_nonclipped)
       : views::WebView(browser_context),
         initiator_observer_(web_contents),
-        impl_(new ConstrainedWebDialogDelegateViews(browser_context, delegate,
+        impl_(new ConstrainedWebDialogDelegateViews(browser_context,
+                                                    delegate,
                                                     &initiator_observer_,
                                                     this)),
         min_size_(min_size),
-        max_size_(max_size) {
+        max_size_(max_size),
+        is_nonclipped_(is_nonclipped) {
     SetWebContents(GetWebContents());
     AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
     if (!max_size_.IsEmpty())
       EnableAutoResize();
   }
   ~ConstrainedWebDialogDelegateViewViews() override {}
 
   // ConstrainedWebDialogDelegate:
   const ui::WebDialogDelegate* GetWebDialogDelegate() const override {
     return impl_->GetWebDialogDelegate();
@@ skipping 66 matching lines @@
     if (!max_size_.IsEmpty())
       EnableAutoResize();
   }
   void RenderViewHostChanged(content::RenderViewHost* old_host,
                              content::RenderViewHost* new_host) override {
     if (!max_size_.IsEmpty())
       EnableAutoResize();
   }
   void DocumentOnLoadCompletedInMainFrame() override {
     if (!max_size_.IsEmpty() && initiator_observer_.web_contents()) {
-      web_modal::WebContentsModalDialogManager::FromWebContents(
-          initiator_observer_.web_contents())
-          ->ShowModalDialog(GetWidget()->GetNativeWindow());
+      if (is_nonclipped_) {
+        web_modal::WebContentsModalDialogManager::FromWebContents(

[Lei Zhang, 2016/08/18 20:30:57]

Combine the same code in the if and else branch for getting the
WebContentsModalDialogManager*.

[rbpotter, 2016/08/19 01:59:09]

Non applicable at this point, this code was refactored in a patch that landed
early this morning...

+            initiator_observer_.web_contents())
+            ->ShowNonClippedModalDialog(GetWidget()->GetNativeWindow());
+      } else {
+        web_modal::WebContentsModalDialogManager::FromWebContents(
+            initiator_observer_.web_contents())
+            ->ShowModalDialog(GetWidget()->GetNativeWindow());
+      }
     }
   }
 
  private:
   void EnableAutoResize() {
     content::RenderViewHost* render_view_host =
         GetWebContents()->GetRenderViewHost();
     render_view_host->EnableAutoResize(min_size_, max_size_);
   }
 
   InitiatorWebContentsObserver initiator_observer_;
 
   std::unique_ptr<ConstrainedWebDialogDelegateViews> impl_;
 
   // Minimum and maximum sizes to determine dialog bounds for auto-resizing.
   const gfx::Size min_size_;
   const gfx::Size max_size_;
 
+  // If true, dialog has bounds that are not constrained by the parent window's
+  // bounds, so can extend outside of the parent window when resized

[Lei Zhang, 2016/08/18 20:30:57]

s/so/so it/

[rbpotter, 2016/08/19 01:59:09]

Done.

+  const bool is_nonclipped_;
+
   DISALLOW_COPY_AND_ASSIGN(ConstrainedWebDialogDelegateViewViews);
 };
 
 }  // namespace
 
 ConstrainedWebDialogDelegate* ShowConstrainedWebDialog(
     content::BrowserContext* browser_context,
     ui::WebDialogDelegate* delegate,
     content::WebContents* web_contents) {
   ConstrainedWebDialogDelegateViewViews* dialog =
-      new ConstrainedWebDialogDelegateViewViews(
-          browser_context, delegate, web_contents,
-          gfx::Size(), gfx::Size());
+      new ConstrainedWebDialogDelegateViewViews(browser_context, delegate,
+                                                web_contents, gfx::Size(),
+                                                gfx::Size(), false);
   constrained_window::ShowWebModalDialogViews(dialog, web_contents);
   return dialog;
 }
 
+ConstrainedWebDialogDelegate* ShowNonClippedConstrainedWebDialog(
+    content::BrowserContext* browser_context,
+    ui::WebDialogDelegate* delegate,
+    content::WebContents* web_contents) {
+  ConstrainedWebDialogDelegateViewViews* dialog =
+      new ConstrainedWebDialogDelegateViewViews(browser_context, delegate,
+                                                web_contents, gfx::Size(),
+                                                gfx::Size(), true);
+  constrained_window::ShowNonClippedWebModalDialogViews(dialog, web_contents);
+  return dialog;
+}
+
 ConstrainedWebDialogDelegate* ShowConstrainedWebDialogWithAutoResize(
     content::BrowserContext* browser_context,
     ui::WebDialogDelegate* delegate,
     content::WebContents* web_contents,
     const gfx::Size& min_size,
     const gfx::Size& max_size) {
   DCHECK(!min_size.IsEmpty());
   DCHECK(!max_size.IsEmpty());
   ConstrainedWebDialogDelegateViewViews* dialog =
       new ConstrainedWebDialogDelegateViewViews(
-          browser_context, delegate, web_contents,
-          min_size, max_size);
+          browser_context, delegate, web_contents, min_size, max_size, false);
   constrained_window::CreateWebModalDialogViews(dialog, web_contents);
   return dialog;
 }