Created min size for print preview dialog and modified to allow the

chrome/browser/printing/print_preview_dialog_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_preview_dialog_controller.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 60 matching lines @@
 };
 
 PrintPreviewDialogDelegate::PrintPreviewDialogDelegate(WebContents* initiator)
     : initiator_(initiator) {
 }
 
 PrintPreviewDialogDelegate::~PrintPreviewDialogDelegate() {
 }
 
 ui::ModalType PrintPreviewDialogDelegate::GetDialogModalType() const {
-  // Not used, returning dummy value.
-  NOTREACHED();
-  return ui::MODAL_TYPE_WINDOW;
+  return ui::MODAL_TYPE_CHILD;
 }
 
 base::string16 PrintPreviewDialogDelegate::GetDialogTitle() const {
   // Only used on Windows? UI folks prefer no title.
   return base::string16();
 }
 
 GURL PrintPreviewDialogDelegate::GetDialogContentURL() const {
   return GURL(chrome::kChromeUIPrintURL);
 }
 
 void PrintPreviewDialogDelegate::GetWebUIMessageHandlers(
     std::vector<WebUIMessageHandler*>* /* handlers */) const {
   // PrintPreviewUI adds its own message handlers.
 }
 
 void PrintPreviewDialogDelegate::GetDialogSize(gfx::Size* size) const {
   DCHECK(size);
-  const gfx::Size kMinDialogSize(800, 480);
   const int kBorder = 25;
+  const gfx::Size kMinDialogSize(438, 455);
+// keeps Mac behavior the same as before new unclipped dialogs

[Mike Wittman, 2016/08/15 19:36:37]

Can you provide more context here on the differences between Mac and non-Mac
behavior, to justify the different setting? Also, comments should be a full
sentence, capitalized with proper punctuation (same thing below).

[rbpotter, 2016/08/15 21:32:54]

Done.

+#if defined(OS_MACOSX)
+  kMinDialogSize.set_width(800);

[Mike Wittman, 2016/08/15 19:36:37]

I don't think this will compile on Mac. Better would be:

#if defined(OS_MACOSX)
  const gfx::Size kMinDialogSize(800, 480);
#else
  const gfx::Size kMinDialogSize(438, 455);
#endif

That said, I'm not qualified to judge the content of the Mac-specific settings
here... I'll leave that to thestig@.

[rbpotter, 2016/08/15 21:32:54]

Done.

+  kMinDialogSize.set_height(480);
+#endif
   *size = kMinDialogSize;
-
   web_modal::WebContentsModalDialogHost* host = nullptr;
   content::WebContents* outermost_web_contents =
       guest_view::GuestViewBase::GetTopLevelWebContents(initiator_);
   Browser* browser = chrome::FindBrowserWithWebContents(outermost_web_contents);
   if (browser)
     host = browser->window()->GetWebContentsModalDialogHost();
 
   if (host)
     size->SetToMax(host->GetMaximumDialogSize());
   else
     size->SetToMax(outermost_web_contents->GetContainerBounds().size());
-  size->Enlarge(-2 * kBorder, -kBorder);
-
+  int expand_width =
+      std::min(size->width() - kMinDialogSize.width(), 2 * kBorder);
+  int expand_height =
+      std::min(size->height() - kMinDialogSize.height(), kBorder);
+// keeps Mac behavior the same as before new unclipped dialogs
+#if defined(OS_MACOSX)
+  expand_width = 2*kBorder;

[Mike Wittman, 2016/08/15 19:36:37]

#ifdef's are much easier to understand when the platform-specific logic is
cleanly factored into each branch. e.g.

#if defined(OS_MACOSX)
  size->Enlarge(-2*kBorder, -kBorder);
#else
  int expand_width =
      std::min(size->width() - kMinDialogSize.width(), 2 * kBorder);
  int expand_height =
      std::min(size->height() - kMinDialogSize.height(), kBorder);
  size->Enlarge(-expand_width, -expand_height);
#endif

[rbpotter, 2016/08/15 21:32:54]

Done.

+  expand_height = kBorder;
+#endif
+  size->Enlarge(-expand_width, -expand_height);
 #if defined(OS_MACOSX)
   // Limit the maximum size on MacOS X.
   // http://crbug.com/105815
   const gfx::Size kMaxDialogSize(1000, 660);
   size->SetToMin(kMaxDialogSize);
 #endif
 }
 
 std::string PrintPreviewDialogDelegate::GetDialogArgs() const {
   return std::string();
@@ skipping 229 matching lines @@
 
   RemoveInitiator(contents);
 }
 
 WebContents* PrintPreviewDialogController::CreatePrintPreviewDialog(
     WebContents* initiator) {
   base::AutoReset<bool> auto_reset(&is_creating_print_preview_dialog_, true);
 
   // The dialog delegates are deleted when the dialog is closed.
   ConstrainedWebDialogDelegate* web_dialog_delegate =
-      ShowConstrainedWebDialog(initiator->GetBrowserContext(),
-                               new PrintPreviewDialogDelegate(initiator),
-                               initiator);
-
+      ShowNonClippedConstrainedWebDialog(
+          initiator->GetBrowserContext(),
+          new PrintPreviewDialogDelegate(initiator), initiator);
   WebContents* preview_dialog = web_dialog_delegate->GetWebContents();
 
   // Clear the zoom level for the print preview dialog so it isn't affected by
   // the default zoom level. This also controls the zoom level of the OOP PDF
   // extension when iframed by the print preview dialog.
   GURL print_url(chrome::kChromeUIPrintURL);
   content::HostZoomMap::Get(preview_dialog->GetSiteInstance())
       ->SetZoomLevelForHostAndScheme(print_url.scheme(), print_url.host(), 0);
   PrintViewManager::CreateForWebContents(preview_dialog);
   extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
@@ skipping 85 matching lines @@
   if (initiator) {
     RemoveObservers(initiator);
     PrintViewManager::FromWebContents(initiator)->PrintPreviewDone();
   }
 
   preview_dialog_map_.erase(preview_dialog);
   RemoveObservers(preview_dialog);
 }
 
 }  // namespace printing