Created min size for print preview dialog and modified to allow the

chrome/browser/printing/print_preview_dialog_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_preview_dialog_controller.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 60 matching lines @@
 };
 
 PrintPreviewDialogDelegate::PrintPreviewDialogDelegate(WebContents* initiator)
     : initiator_(initiator) {
 }
 
 PrintPreviewDialogDelegate::~PrintPreviewDialogDelegate() {
 }
 
 ui::ModalType PrintPreviewDialogDelegate::GetDialogModalType() const {
-  // Not used, returning dummy value.
-  NOTREACHED();
-  return ui::MODAL_TYPE_WINDOW;
+  return ui::MODAL_TYPE_CHILD;
 }
 
 base::string16 PrintPreviewDialogDelegate::GetDialogTitle() const {
   // Only used on Windows? UI folks prefer no title.
   return base::string16();
 }
 
 GURL PrintPreviewDialogDelegate::GetDialogContentURL() const {
   return GURL(chrome::kChromeUIPrintURL);
 }
 
 void PrintPreviewDialogDelegate::GetWebUIMessageHandlers(
     std::vector<WebUIMessageHandler*>* /* handlers */) const {
   // PrintPreviewUI adds its own message handlers.
 }
 
 void PrintPreviewDialogDelegate::GetDialogSize(gfx::Size* size) const {
   DCHECK(size);
-  const gfx::Size kMinDialogSize(800, 480);
+  // Modified to match requested size. Previously: 800, 480.

[Mike Wittman, 2016/08/12 22:51:34]

This comment likely can be removed. Anyone who wants to understand the history
of kMinDialogSize can look at the file's git history.

[rbpotter, 2016/08/15 18:03:45]

Done.

+  const gfx::Size kMinDialogSize(438, 455);

[Mike Wittman, 2016/08/12 22:51:34]

Should this be sized differently depending on whether
wm::kHasIndependentBoundsKey is supported?

[rbpotter, 2016/08/15 18:03:45]

If there's not independent bounds key, the dialog ignores its minimum size
entirely and just sizes down to the size of the parent window. The only platform
that could be affected is Mac, so I am adding a couple Mac only lines to ensure
that on Mac the behavior is the same as before.

   const int kBorder = 25;
   *size = kMinDialogSize;
 
   web_modal::WebContentsModalDialogHost* host = nullptr;
   content::WebContents* outermost_web_contents =
       guest_view::GuestViewBase::GetTopLevelWebContents(initiator_);
   Browser* browser = chrome::FindBrowserWithWebContents(outermost_web_contents);
   if (browser)
     host = browser->window()->GetWebContentsModalDialogHost();
 
   if (host)
     size->SetToMax(host->GetMaximumDialogSize());
   else
     size->SetToMax(outermost_web_contents->GetContainerBounds().size());
-  size->Enlarge(-2 * kBorder, -kBorder);
+  int expand_width =

[Mike Wittman, 2016/08/12 22:51:34]

Same question here.

[rbpotter, 2016/08/15 18:03:45]

See above

+      std::min(size->width() - kMinDialogSize.width(), 2 * kBorder);
+  int expand_height =
+      std::min(size->height() - kMinDialogSize.height(), kBorder);
+  size->Enlarge(-expand_width, -expand_height);
 
 #if defined(OS_MACOSX)
   // Limit the maximum size on MacOS X.
   // http://crbug.com/105815
   const gfx::Size kMaxDialogSize(1000, 660);
   size->SetToMin(kMaxDialogSize);
 #endif
 }
 
 std::string PrintPreviewDialogDelegate::GetDialogArgs() const {
@@ skipping 229 matching lines @@
   }
 
   RemoveInitiator(contents);
 }
 
 WebContents* PrintPreviewDialogController::CreatePrintPreviewDialog(
     WebContents* initiator) {
   base::AutoReset<bool> auto_reset(&is_creating_print_preview_dialog_, true);
 
   // The dialog delegates are deleted when the dialog is closed.
+#if defined(OS_MACOSX)

[Mike Wittman, 2016/08/12 22:51:34]

Can we drop the #if part here and just have ShowTopLevelConstrainedWebDialog
invoke ShowConstrainedWebDialog within its implementation on Mac?

[rbpotter, 2016/08/15 18:03:45]

Done.

+  ConstrainedWebDialogDelegate* web_dialog_delegate = ShowConstrainedWebDialog(
+      initiator->GetBrowserContext(), new PrintPreviewDialogDelegate(initiator),
+      initiator);
+#else
   ConstrainedWebDialogDelegate* web_dialog_delegate =
-      ShowConstrainedWebDialog(initiator->GetBrowserContext(),
-                               new PrintPreviewDialogDelegate(initiator),
-                               initiator);
+      ShowTopLevelConstrainedWebDialog(
+          initiator->GetBrowserContext(),
+          new PrintPreviewDialogDelegate(initiator), initiator);
+#endif
 
   WebContents* preview_dialog = web_dialog_delegate->GetWebContents();
 
   // Clear the zoom level for the print preview dialog so it isn't affected by
   // the default zoom level. This also controls the zoom level of the OOP PDF
   // extension when iframed by the print preview dialog.
   GURL print_url(chrome::kChromeUIPrintURL);
   content::HostZoomMap::Get(preview_dialog->GetSiteInstance())
       ->SetZoomLevelForHostAndScheme(print_url.scheme(), print_url.host(), 0);
   PrintViewManager::CreateForWebContents(preview_dialog);
@@ skipping 86 matching lines @@
   if (initiator) {
     RemoveObservers(initiator);
     PrintViewManager::FromWebContents(initiator)->PrintPreviewDone();
   }
 
   preview_dialog_map_.erase(preview_dialog);
   RemoveObservers(preview_dialog);
 }
 
 }  // namespace printing