Created min size for print preview dialog and modified to allow the

chrome/browser/printing/print_preview_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_preview_dialog_controller.h"
 
 #include <memory>
 #include <string>
 
 #include "chrome/browser/printing/print_preview_test.h"
 #include "chrome/browser/printing/print_view_manager.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/test/mock_render_process_host.h"
 #include "content/public/test/web_contents_tester.h"
+#include "ui/views/widget/widget.h"
+#include "ui/views/window/dialog_delegate.h"
 
 using content::WebContents;
 using content::WebContentsObserver;
 
 namespace {
 // content::WebContentsDelegate destructor is protected: subclass for testing.
 class TestWebContentsDelegate : public content::WebContentsDelegate {};
 
 class PrintPreviewDialogDestroyedObserver : public WebContentsObserver {
  public:
   explicit PrintPreviewDialogDestroyedObserver(WebContents* dialog)
       : WebContentsObserver(dialog),
         dialog_destroyed_(false) {
   }
   ~PrintPreviewDialogDestroyedObserver() override {}
 
   bool dialog_destroyed() const { return dialog_destroyed_; }
 
  private:
   // content::WebContentsObserver implementation.
   void WebContentsDestroyed() override { dialog_destroyed_ = true; }
 
   bool dialog_destroyed_;
 
   DISALLOW_COPY_AND_ASSIGN(PrintPreviewDialogDestroyedObserver);
 };
 
+#if defined(USE_AURA)
+class PrintPreviewDialogControllerTest:
+  public printing::PrintPreviewDialogController {
+
+ public:
+  explicit PrintPreviewDialogControllerTest(gfx::NativeView context):
+    context_(context) {}
+
+ // Need to override the function to get the delegate so that it uses the
+  // correct window.
+  ConstrainedWebDialogDelegate* GetWebDialogDelegate(
+      WebContents* initiator) override {
+    ConstrainedWebDialogDelegate* dialog =
+      ShowTopLevelConstrainedWebDialogInWindow(
+           initiator->GetBrowserContext(),
+           printing::GetPrintPreviewDialogDelegate(initiator),
+           initiator, context_);
+    return dialog;
+  }
+
+ protected:
+  ~PrintPreviewDialogControllerTest() override {}
+
+ private:
+  gfx::NativeWindow context_;
+
+};
+#endif
 }  // namespace
 
 namespace printing {
 
 using PrintPreviewDialogControllerUnitTest = PrintPreviewTest;
 
 // Create/Get a preview dialog for initiator.
 TEST_F(PrintPreviewDialogControllerUnitTest, GetOrCreatePreviewDialog) {
   // Lets start with one window with one tab.
   EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
   EXPECT_EQ(0, browser()->tab_strip_model()->count());
   chrome::NewTab(browser());
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
 
   // Create a reference to initiator contents.
   WebContents* initiator = browser()->tab_strip_model()->GetActiveWebContents();
-
+#if defined(USE_AURA)
+  PrintPreviewDialogController* dialog_controller =
+      new PrintPreviewDialogControllerTest(GetContext());
+#else
   PrintPreviewDialogController* dialog_controller =
       PrintPreviewDialogController::GetInstance();
+#endif
   ASSERT_TRUE(dialog_controller);
 
   // Get the preview dialog for initiator.
   PrintViewManager::FromWebContents(initiator)->PrintPreviewNow(false);
   WebContents* preview_dialog =
       dialog_controller->GetOrCreatePreviewDialog(initiator);
 
   // New print preview dialog is a constrained window, so the number of tabs is
   // still 1.
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
   EXPECT_NE(initiator, preview_dialog);
 
   // Get the print preview dialog for the same initiator.
   WebContents* new_preview_dialog =
       dialog_controller->GetOrCreatePreviewDialog(initiator);
 
   // Preview dialog already exists. Tab count remains the same.
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
 
   // 1:1 relationship between initiator and preview dialog.
   EXPECT_EQ(new_preview_dialog, preview_dialog);
+  preview_dialog->Close();
+  initiator->Close();
 }
 
 // Tests multiple print preview dialogs exist in the same browser for different
 // initiators. If a preview dialog already exists for an initiator, that
 // initiator gets focused.
 TEST_F(PrintPreviewDialogControllerUnitTest, MultiplePreviewDialogs) {
   // Lets start with one window and two tabs.
   EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
   TabStripModel* tab_strip_model = browser()->tab_strip_model();
   ASSERT_TRUE(tab_strip_model);
 
   EXPECT_EQ(0, tab_strip_model->count());
 
   // Create some new initiators.
   chrome::NewTab(browser());
   WebContents* web_contents_1 = tab_strip_model->GetActiveWebContents();
   ASSERT_TRUE(web_contents_1);
 
   chrome::NewTab(browser());
   WebContents* web_contents_2 = tab_strip_model->GetActiveWebContents();
   ASSERT_TRUE(web_contents_2);
   EXPECT_EQ(2, tab_strip_model->count());
 
+#if defined(USE_AURA)
+  PrintPreviewDialogController* dialog_controller =
+      new PrintPreviewDialogControllerTest(GetContext());
+#else
   PrintPreviewDialogController* dialog_controller =
       PrintPreviewDialogController::GetInstance();
+#endif
   ASSERT_TRUE(dialog_controller);
 
   // Create preview dialog for |web_contents_1|
   PrintViewManager::FromWebContents(web_contents_1)->PrintPreviewNow(false);
   WebContents* preview_dialog_1 =
       dialog_controller->GetOrCreatePreviewDialog(web_contents_1);
 
   EXPECT_NE(web_contents_1, preview_dialog_1);
   EXPECT_EQ(2, tab_strip_model->count());
 
@@ skipping 20 matching lines @@
   EXPECT_EQ(-1, preview_dialog_2_index);
 
   // Since |preview_dialog_2_index| was the most recently created dialog, its
   // initiator should have focus.
   EXPECT_EQ(tab_2_index, tab_strip_model->active_index());
 
   // When we get the preview dialog for |web_contents_1|,
   // |preview_dialog_1| is activated and focused.
   dialog_controller->GetOrCreatePreviewDialog(web_contents_1);
   EXPECT_EQ(tab_1_index, tab_strip_model->active_index());
+
+  preview_dialog_1->Close();
+  web_contents_1->Close();
+  preview_dialog_2->Close();
+  web_contents_2->Close();
 }
 
 // Check clearing the initiator details associated with a print preview dialog
 // allows the initiator to create another print preview dialog.
 TEST_F(PrintPreviewDialogControllerUnitTest, ClearInitiatorDetails) {
   // Lets start with one window with one tab.
   EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
   EXPECT_EQ(0, browser()->tab_strip_model()->count());
   chrome::NewTab(browser());
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
 
   // Create a reference to initiator contents.
   WebContents* initiator = browser()->tab_strip_model()->GetActiveWebContents();
 
+#if defined(USE_AURA)
+  PrintPreviewDialogController* dialog_controller =
+      new PrintPreviewDialogControllerTest(GetContext());
+#else
   PrintPreviewDialogController* dialog_controller =
       PrintPreviewDialogController::GetInstance();
+#endif
   ASSERT_TRUE(dialog_controller);
 
   // Get the preview dialog for the initiator.
   PrintViewManager::FromWebContents(initiator)->PrintPreviewNow(false);
   WebContents* preview_dialog =
       dialog_controller->GetOrCreatePreviewDialog(initiator);
 
   // New print preview dialog is a constrained window, so the number of tabs is
   // still 1.
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
   EXPECT_NE(initiator, preview_dialog);
 
   // Clear the initiator details associated with the preview dialog.
   dialog_controller->EraseInitiatorInfo(preview_dialog);
 
   // Get a new print preview dialog for the initiator.
   WebContents* new_preview_dialog =
       dialog_controller->GetOrCreatePreviewDialog(initiator);
 
   // New print preview dialog is a constrained window, so the number of tabs is
   // still 1.
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
   // Verify a new print preview dialog has been created.
   EXPECT_NE(new_preview_dialog, preview_dialog);
+
+  initiator->Close();
+  new_preview_dialog->Close();
 }
 
 // Test that print preview dialogs close on navigation to new pages
 // and when navigating to old pages via fwd/back, but that auto navigation
 // (typed + address bar) to an existing page as occurs in gmail does not cause
 // the dialogs to close.
 TEST_F(PrintPreviewDialogControllerUnitTest, CloseDialogOnNavigation) {
   // Two similar URLs (same webpage, different URL fragments)
   GURL tiger_barb("https://www.google.com/#q=tiger+barb");
   GURL tiger("https://www.google.com/#q=tiger");
 
   // Set up by opening a new tab and getting web contents
   EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
   EXPECT_EQ(0, browser()->tab_strip_model()->count());
   chrome::NewTab(browser());
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
   WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
   content::NavigationController& nav_controller = web_contents->GetController();
 
   // Navigate to first page
   nav_controller.LoadURL(tiger, content::Referrer(),
                          ui::PageTransitionFromInt(ui::PAGE_TRANSITION_LINK),
                          std::string());
   CommitPendingLoad(&nav_controller);
   EXPECT_EQ(tiger, web_contents->GetLastCommittedURL());
 
   // Get the preview dialog
+#if defined(USE_AURA)
+  PrintPreviewDialogController* dialog_controller =
+      new PrintPreviewDialogControllerTest(GetContext());
+#else
   PrintPreviewDialogController* dialog_controller =
       PrintPreviewDialogController::GetInstance();
+#endif
   ASSERT_TRUE(dialog_controller);
   WebContents* tiger_preview_dialog =
       dialog_controller->GetOrCreatePreviewDialog(web_contents);
   PrintViewManager* manager = PrintViewManager::FromWebContents(web_contents);
   manager->PrintPreviewNow(false);
 
   // New print preview dialog is a constrained window, so the number of tabs is
   // still 1.
   EXPECT_EQ(1, browser()->tab_strip_model()->count());
   EXPECT_NE(web_contents, tiger_preview_dialog);
@@ skipping 59 matching lines @@
   // preview now should return false, dialog is still alive, and the dialog
   // returned by GetOrCreatePreviewDialog should be the same as the earlier
   // dialog.
   EXPECT_FALSE(manager->PrintPreviewNow(false));
   EXPECT_FALSE(tiger_2_destroyed.dialog_destroyed());
   WebContents* tiger_preview_dialog_2b =
       dialog_controller->GetOrCreatePreviewDialog(web_contents);
   ASSERT_TRUE(tiger_preview_dialog_2b);
   EXPECT_EQ(tiger_preview_dialog_2b, tiger_preview_dialog_2);
   EXPECT_NE(tiger_preview_dialog_2b, web_contents);
+  tiger_preview_dialog_2->Close();
+  web_contents->Close();
 }
 
 // Tests preview dialog controller cleans up correctly and does not throw errors
 // on a renderer process crash. Checks that the renderer process closed
 // notification is still received even if one of two preview dialogs with the
 // same renderer process host is closed before the process "crashes".
 TEST_F(PrintPreviewDialogControllerUnitTest, MultiplePreviewDialogsClose) {
   // Set up the browser.
   EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
   TabStripModel* tab_strip_model = browser()->tab_strip_model();
   ASSERT_TRUE(tab_strip_model);
   EXPECT_EQ(0, tab_strip_model->count());
 
   // Create a new tab with contents |web_contents_1|
   chrome::NewTab(browser());
   WebContents* web_contents_1 = tab_strip_model->GetActiveWebContents();
   ASSERT_TRUE(web_contents_1);
   EXPECT_EQ(1, tab_strip_model->count());
+#if defined(USE_AURA)
+  PrintPreviewDialogController* dialog_controller =
+      new PrintPreviewDialogControllerTest(GetContext());
+#else
   PrintPreviewDialogController* dialog_controller =
       PrintPreviewDialogController::GetInstance();
+#endif
   ASSERT_TRUE(dialog_controller);
 
   // Create preview dialog for |web_contents_1|. Should not create a new tab.
   PrintViewManager::FromWebContents(web_contents_1)->PrintPreviewNow(false);
   WebContents* preview_dialog_1 =
       dialog_controller->GetOrCreatePreviewDialog(web_contents_1);
   EXPECT_NE(web_contents_1, preview_dialog_1);
   EXPECT_EQ(1, tab_strip_model->count());
 
   // Create a new tab with contents |web_contents_2|
@@ skipping 19 matching lines @@
   EXPECT_EQ(1, tab_strip_model->count());
 
   // Simulate a crash of the render process host for |web_contents_2|. Print
   // preview controller should exit cleanly and not crash.
   content::MockRenderProcessHost* rph =
       static_cast<content::MockRenderProcessHost*>(
           web_contents_2->GetRenderViewHost()->GetProcess());
   rph->SimulateCrash();
 }
 }  // namespace printing