Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2172343002: Have SkRasterPipelineBlitter take over for 565 when it can. (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
Brian Osman, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Have SkRasterPipelineBlitter take over for 565 when it can. This is an experiment / demo to have our 565 backend fold into SkRasterPipelineBlitter as it grows more powerful. I plan to follow up with the same for the other 8888 format. Blur mask filters look significantly different (better) after this change. We keep the full 13-14-13 bits of precision for mask blits, where the old code uses 11-11-10 bit intermediates. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2172343002 Committed: https://skia.googlesource.com/skia/+/8e4373f40be3362a2756c6522df3541253d0edb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -13 lines) Patch
M src/core/SkRasterPipelineBlitter.cpp View 11 chunks +109 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mtklein_C
Please note the logic I'm using for how to treat SkColor: (has color space) ? ...
4 years, 5 months ago (2016-07-22 19:08:31 UTC) #7
reed1
lgtm
4 years, 5 months ago (2016-07-22 21:06:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172343002/1
4 years, 5 months ago (2016-07-22 21:19:33 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 21:20:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8e4373f40be3362a2756c6522df3541253d0edb0

Powered by Google App Engine
This is Rietveld 408576698