Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2172333002: Organize typemaps in Blink (Closed)

Created:
4 years, 5 months ago by xlai (Olivia)
Modified:
4 years, 5 months ago
Reviewers:
pdr., yzshen1, jbroman
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, cc-bugs_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Organize typemaps in Blink This CL organizes the typemaps in Blink GN build. Previously, we dump typemaps in Blink to third_party/WebKit/Source/platform/mojo/blink_typemaps.gni, even though some of them are used by third_party/WebKit/public/. This is wrong and inconsistent with GYP build. So I added a new typemaps.gni in WebKit/public to collect them separately. TBR=pdr@chromium.org BUG=629566 Committed: https://crrev.com/b491c565c55b8a13862ae5c343c10c1f0025122d Cr-Commit-Position: refs/heads/master@{#407277}

Patch Set 1 : reorganize #

Total comments: 2

Patch Set 2 : Nits #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M mojo/public/tools/bindings/blink_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/mojo/blink_typemaps.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
A + third_party/WebKit/public/blink_typemaps.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
xlai (Olivia)
yzshen@, jbroman@: I'm extracting part of the previous CL (https://codereview.chromium.org/2161993004/) here as suggested. This CL ...
4 years, 5 months ago (2016-07-22 17:51:52 UTC) #3
jbroman
Seems reasonable enough. lgtm (with nits). https://codereview.chromium.org/2172333002/diff/20001/third_party/WebKit/public/blink.gyp File third_party/WebKit/public/blink.gyp (right): https://codereview.chromium.org/2172333002/diff/20001/third_party/WebKit/public/blink.gyp#newcode132 third_party/WebKit/public/blink.gyp:132: 'includes': [ nit: ...
4 years, 5 months ago (2016-07-22 18:05:00 UTC) #4
yzshen1
lgtm
4 years, 5 months ago (2016-07-22 18:59:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172333002/60001
4 years, 5 months ago (2016-07-22 20:27:59 UTC) #16
commit-bot: I haz the power
Failed to apply the patch.
4 years, 5 months ago (2016-07-22 22:03:17 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 22:03:32 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b491c565c55b8a13862ae5c343c10c1f0025122d
Cr-Commit-Position: refs/heads/master@{#407277}

Powered by Google App Engine
This is Rietveld 408576698