Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 217233005: Revert 260917 "Media Galleries API Metadata: Image metadata" (Closed)

Created:
6 years, 8 months ago by ccameron
Modified:
6 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 260917 "Media Galleries API Metadata: Image metadata" > Media Galleries API Metadata: Image metadata > > Enables libexif and uses it to parse some image tags into the GetMetadata call. > > BUG=318450 > > Review URL: https://codereview.chromium.org/191583002 TBR=tommycli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -601 lines) Patch
M trunk/src/build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/chrome.gyp View 3 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/chrome.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_dll_bundle.gypi View 2 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/media_galleries.idl View 1 chunk +1 line, -14 lines 0 comments Download
M trunk/src/chrome/installer/linux/debian/expected_deps View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.amd64 View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/installer/mini_installer/chrome.release View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/sync_integration_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js View 2 chunks +1 line, -23 lines 0 comments Download
M trunk/src/chrome/test/functional/stress.py View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/tools/build/chromeos/FILES.cfg View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/tools/build/mac/TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/tools/build/mac/dump_product_syms View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/unit_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/utility/media_galleries/image_metadata_extractor.h View 1 chunk +0 lines, -84 lines 0 comments Download
D trunk/src/chrome/utility/media_galleries/image_metadata_extractor.cc View 1 chunk +0 lines, -279 lines 0 comments Download
D trunk/src/chrome/utility/media_galleries/image_metadata_extractor_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M trunk/src/chrome/utility/media_galleries/media_metadata_parser.cc View 5 chunks +0 lines, -57 lines 0 comments Download
M trunk/src/third_party/libexif/libexif.gyp View 3 chunks +15 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
6 years, 8 months ago (2014-04-01 19:50:42 UTC) #1
ccameron
Committed patchset #1 manually as r260931 (tree was closed).
6 years, 8 months ago (2014-04-01 19:51:06 UTC) #2
Lei Zhang
Please include some more notes about why you reverted in the future. If I weren't ...
6 years, 8 months ago (2014-04-01 20:01:07 UTC) #3
ccameron
6 years, 8 months ago (2014-04-01 20:03:10 UTC) #4
Good point -- sorry, I included it in an email but not in the revert.

CCing here:

I'm seeing:

/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python
/b/build/slave/Mac_Release__Intel_/build/swarming.client/run_isolated.py
-H acbdbbe1ef5663242dac6bace77edcc351c2a98d -I
https://isolateserver.appspot.com -- --enable-gpu
--test-launcher-jobs=1 --test-launcher-print-test-stdio=always
--gtest_filter=TabCapturePerformanceTest*,CastV2PerformanceTest**dyld:
Library not loaded: @rpath/libexif.dylib
*  Referenced from:
/tmp/run_tha_testjNSrNY/out/Release/performance_browser_tests
  Reason: image not found
exit code (as seen by runtest.py): 251
@@@STEP_FAILURE@@@
@@@STEP_TEXT@tab_capture_performance_tests@@@
@@@STEP_TEXT@<div class="BuildResultInfo">@@@
@@@STEP_TEXT@</div>@@@
@@@STEP_LOG_LINE@graphs.dat@{}@@@
@@@STEP_LOG_END_PERF@graphs.dat@tab_capture_performance@@@


In this log:
http://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%29...

I'd guess it to be related to:
http://src.chromium.org/viewvc/chrome?revision=260917&view=revision

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698