Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: build/android/resource_sizes.py

Issue 2172303002: 🎫 Track uncompressed sizes in resource_sizes.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/resource_sizes.py
diff --git a/build/android/resource_sizes.py b/build/android/resource_sizes.py
index 6d59f8a7fc85e17d47ffc23dc3fc717238a6331d..16f9e61004f101503fd7dac01ec49a17d08b209b 100755
--- a/build/android/resource_sizes.py
+++ b/build/android/resource_sizes.py
@@ -217,17 +217,20 @@ def PrintApkAnalysis(apk_filename, chartjson=None):
total_install_size = total_apk_size
for group in FILE_GROUPS:
- apk_size = sum(member.compress_size for member in found_files[group])
- install_size = apk_size
- install_bytes = sum(f.file_size for f in found_files[group]
- if group.extracted(f.filename))
+ uncompressed_size = sum(member.file_size for member in found_files[group])
+ packed_size = sum(member.compress_size for member in found_files[group])
+ install_size = packed_size
+ install_bytes = sum(member.file_size for member in found_files[group]
+ if group.extracted(member.filename))
install_size += install_bytes
total_install_size += install_bytes
ReportPerfResult(chartjson, apk_basename + '_Breakdown',
- group.name + ' size', apk_size, 'bytes')
+ group.name + ' size', packed_size, 'bytes')
ReportPerfResult(chartjson, apk_basename + '_InstallBreakdown',
group.name + ' size', install_size, 'bytes')
+ ReportPerfResult(chartjson, apk_basename + '_Uncompressed',
+ group.name + ' size', uncompressed_size, 'bytes')
transfer_size = _CalculateCompressedSize(apk_filename)
ReportPerfResult(chartjson, apk_basename + '_InstallSize',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698