Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2172303002: 🎫 Track uncompressed sizes in resource_sizes.py (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, pasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track uncompressed sizes in resource_sizes.py We were tracking size-within-apk, and size-within-apk+extracted size, but it's also useful to track uncompressed size for things like the native library & dex file. BUG=none Committed: https://crrev.com/8b895f66dfce62d1e1c9517e04d3183690c4a07d Cr-Commit-Position: refs/heads/master@{#407550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M build/android/resource_sizes.py View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
agrieve
On 2016/07/22 17:02:15, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:rnephew@chromium.org
4 years, 5 months ago (2016-07-22 17:02:21 UTC) #3
rnephew (Reviews Here)
On 2016/07/22 17:02:21, agrieve wrote: > On 2016/07/22 17:02:15, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
4 years, 5 months ago (2016-07-22 17:04:59 UTC) #4
agrieve
On 2016/07/22 17:04:59, rnephew (Reviews Here) wrote: > On 2016/07/22 17:02:21, agrieve wrote: > > ...
4 years, 5 months ago (2016-07-22 19:13:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172303002/1
4 years, 5 months ago (2016-07-22 19:13:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/109296)
4 years, 5 months ago (2016-07-22 22:44:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172303002/1
4 years, 5 months ago (2016-07-25 15:42:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/109905)
4 years, 5 months ago (2016-07-25 16:43:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172303002/1
4 years, 5 months ago (2016-07-25 17:41:10 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/109964)
4 years, 5 months ago (2016-07-25 18:54:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172303002/1
4 years, 5 months ago (2016-07-25 19:03:14 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 19:52:42 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 19:56:24 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b895f66dfce62d1e1c9517e04d3183690c4a07d
Cr-Commit-Position: refs/heads/master@{#407550}

Powered by Google App Engine
This is Rietveld 408576698