|
|
Created:
4 years, 5 months ago by agrieve Modified:
4 years, 5 months ago Reviewers:
rnephew (Reviews Here) CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, pasko Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTrack uncompressed sizes in resource_sizes.py
We were tracking size-within-apk, and size-within-apk+extracted size,
but it's also useful to track uncompressed size for things like the
native library & dex file.
BUG=none
Committed: https://crrev.com/8b895f66dfce62d1e1c9517e04d3183690c4a07d
Cr-Commit-Position: refs/heads/master@{#407550}
Patch Set 1 #
Messages
Total messages: 23 (11 generated)
Description was changed from ========== Track uncompressed sizes in resource_sizes.py We were tracking size-within-apk, and size-within-apk+extracted size, but it's also useful to track uncompressed size for things like the native library & dex file. BUG=none ========== to ========== Track uncompressed sizes in resource_sizes.py We were tracking size-within-apk, and size-within-apk+extracted size, but it's also useful to track uncompressed size for things like the native library & dex file. BUG=none ==========
agrieve@chromium.org changed reviewers: + rnephew@chromium.org
On 2016/07/22 17:02:15, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:rnephew@chromium.org
On 2016/07/22 17:02:21, agrieve wrote: > On 2016/07/22 17:02:15, agrieve wrote: > > mailto:agrieve@chromium.org changed reviewers: > > + mailto:rnephew@chromium.org lgtm; we should get someone on speed infra to migrate any data that needs to be migrated to the new labels.
The CQ bit was checked by agrieve@chromium.org
On 2016/07/22 17:04:59, rnephew (Reviews Here) wrote: > On 2016/07/22 17:02:21, agrieve wrote: > > On 2016/07/22 17:02:15, agrieve wrote: > > > mailto:agrieve@chromium.org changed reviewers: > > > + mailto:rnephew@chromium.org > > lgtm; we should get someone on speed infra to migrate any data that needs to be > migrated to the new labels. Unless you're talking about something I don't know about (which is entirely likely), there shouldn't be anything to do. This just adds one extra field, and doesn't rename any existing ones.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Track uncompressed sizes in resource_sizes.py We were tracking size-within-apk, and size-within-apk+extracted size, but it's also useful to track uncompressed size for things like the native library & dex file. BUG=none ========== to ========== Track uncompressed sizes in resource_sizes.py We were tracking size-within-apk, and size-within-apk+extracted size, but it's also useful to track uncompressed size for things like the native library & dex file. BUG=none ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Track uncompressed sizes in resource_sizes.py We were tracking size-within-apk, and size-within-apk+extracted size, but it's also useful to track uncompressed size for things like the native library & dex file. BUG=none ========== to ========== Track uncompressed sizes in resource_sizes.py We were tracking size-within-apk, and size-within-apk+extracted size, but it's also useful to track uncompressed size for things like the native library & dex file. BUG=none Committed: https://crrev.com/8b895f66dfce62d1e1c9517e04d3183690c4a07d Cr-Commit-Position: refs/heads/master@{#407550} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8b895f66dfce62d1e1c9517e04d3183690c4a07d Cr-Commit-Position: refs/heads/master@{#407550} |