src/interpreter/bytecodes.h - Issue 2172233002: [interpreter] Add explicit OSR polling bytecode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecodes.h

Issue 2172233002: [interpreter] Add explicit OSR polling bytecode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_interpreter-osr-1

Patch Set: Minor cleanups. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecodes.h

diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h

index f6c7a2cd69ca9b4a5254549af9abdf224df342b2..214a7f0ac8f6a1882132550e3803c53921aff2db 100644

--- a/src/interpreter/bytecodes.h

+++ b/src/interpreter/bytecodes.h

@@ -260,6 +260,9 @@ namespace interpreter {

/* Perform a stack guard check */ \

V(StackCheck, AccumulatorUse::kNone) \

+ /* Perform a check to trigger on-stack replacement */ \

+ V(OsrPoll, AccumulatorUse::kNone, OperandType::kFlag8) \

rmcilroy 2016/07/25 12:40:23 This is possibly more of an Immediate rather than

Michael Starzinger 2016/07/25 13:40:48 Done. No strong opinion either way, making it Oper

+ \

/* Non-local flow control */ \

V(Throw, AccumulatorUse::kRead) \

V(ReThrow, AccumulatorUse::kRead) \

« src/interpreter/bytecode-generator.cc ('K') | « src/interpreter/bytecode-generator.cc ('k') | src/interpreter/interpreter.cc » ('j') | src/interpreter/interpreter.cc » ('J')