Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2172173002: Avoid generating negative width of columns when the view is too small. (Closed)

Created:
4 years, 5 months ago by yamaguchi
Modified:
4 years, 5 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, hirono
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid generating negative width of columns when the view is too small. This change will make the table columns to expand evenly when the window is resized back to the normal size from a very narrow size, like seen in the linked bug. BUG=629777 Committed: https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac Cr-Commit-Position: refs/heads/master@{#407400}

Patch Set 1 #

Patch Set 2 : Fix comments. #

Patch Set 3 : Add unit test for testSetWidthAndkeepTotal. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 1 chunk +8 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table_unittest.js View 1 2 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
yamaguchi
Added a unit test for resizing a column, which is considered relevant to this change. ...
4 years, 5 months ago (2016-07-22 10:48:05 UTC) #4
fukino
lgtm
4 years, 5 months ago (2016-07-25 02:11:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172173002/40001
4 years, 5 months ago (2016-07-25 02:18:30 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-25 02:57:04 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 02:58:53 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac
Cr-Commit-Position: refs/heads/master@{#407400}

Powered by Google App Engine
This is Rietveld 408576698