Ensure that connection can be closed in response to a data message.

remoting/protocol/webrtc_transport.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/webrtc_transport.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 117 matching lines @@
   explicit SetSessionDescriptionObserver(const ResultCallback& result_callback)
       : result_callback_(result_callback) {}
   ~SetSessionDescriptionObserver() override {}
 
  private:
   ResultCallback result_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(SetSessionDescriptionObserver);
 };
 
-
 }  // namespace
 
 WebrtcTransport::WebrtcTransport(
     rtc::Thread* worker_thread,
     scoped_refptr<TransportContext> transport_context,
     EventHandler* event_handler)
     : worker_thread_(worker_thread),
       transport_context_(transport_context),
       event_handler_(event_handler),
       handshake_hmac_(crypto::HMAC::SHA256),
       weak_factory_(this) {
   transport_context_->set_relay_mode(TransportContext::RelayMode::TURN);
 }
 
-WebrtcTransport::~WebrtcTransport() {}
+WebrtcTransport::~WebrtcTransport() {
+  // Destroy |fake_audio_device_module_| asynchronously. PeerConnection may be
+  // on the stack and so it will be destroyed later. We need to ensures that

[Jamie, 2016/07/23 00:03:48]

s/ensures/ensure/

[Sergey Ulanov, 2016/07/23 06:30:04]

reworded this comment

+  // |fake_audio_device_module_| is destroyed only after that.
+  base::ThreadTaskRunnerHandle::Get()->DeleteSoon(
+      FROM_HERE, fake_audio_device_module_.release());
+}
 
 std::unique_ptr<MessagePipe> WebrtcTransport::CreateOutgoingChannel(
     const std::string& name) {
   return data_stream_adapter_->CreateOutgoingChannel(name);
 }
 
 void WebrtcTransport::Start(
     Authenticator* authenticator,
     SendTransportInfoCallback send_transport_info_callback) {
   DCHECK(thread_checker_.CalledOnValidThread());
@@ skipping 415 matching lines @@
   peer_connection_->Close();
   peer_connection_ = nullptr;
   peer_connection_factory_ = nullptr;
 
   if (error != OK)
     event_handler_->OnWebrtcTransportError(error);
 }
 
 }  // namespace protocol
 }  // namespace remoting