|
|
Created:
4 years, 5 months ago by lshang Modified:
4 years, 5 months ago CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD History: Fix bottom shadow of synced device card when collapsed
Currently for synced device cards, the #history-item-container has a 2px bottom
border, .card-title has a 1px bottom border and the collapse section has no
borders. In this way, the overall synced device card will have a 2px border at
bottom when opened, but will result in a 3px bottom border when the collapse
section is closed, which is too thick.
This CL changed #history-item-container's bottom border to be 1px only and let
collapse section to have a 1px border, so that no matter the collapse section is
opened or closed, the overall synced device card will always have a 2px bottom
border.
BUG=620162
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/34b990b50b984c81eb660e8ceaf9c2d431c7aad6
Cr-Commit-Position: refs/heads/master@{#407429}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== MD History: Fix bottom shadow of synced device card when collapsed BUG= ========== to ========== MD History: Fix bottom shadow of synced device card when collapsed BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD History: Fix bottom shadow of synced device card when collapsed BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Fix bottom shadow of synced device card when collapsed Currently for synced device cards, the #history-item-container has a 2px bottom border, .card-title has a 1px bottom border and the collapse section has no borders. In this way, the overall synced device card will have a 2px border at bottom when opened, but will result in a 3px bottom border when the collapse section is closed, which is too thick. This CL changed #history-item-container's bottom border to be 1px only and let collapse section to have a 1px border, so that no matter the collapse section is opened or closed, the overall synced device card will always have a 2px bottom border. BUG=620162 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD History: Fix bottom shadow of synced device card when collapsed Currently for synced device cards, the #history-item-container has a 2px bottom border, .card-title has a 1px bottom border and the collapse section has no borders. In this way, the overall synced device card will have a 2px border at bottom when opened, but will result in a 3px bottom border when the collapse section is closed, which is too thick. This CL changed #history-item-container's bottom border to be 1px only and let collapse section to have a 1px border, so that no matter the collapse section is opened or closed, the overall synced device card will always have a 2px bottom border. BUG=620162 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Fix bottom shadow of synced device card when collapsed Currently for synced device cards, the #history-item-container has a 2px bottom border, .card-title has a 1px bottom border and the collapse section has no borders. In this way, the overall synced device card will have a 2px border at bottom when opened, but will result in a 3px bottom border when the collapse section is closed, which is too thick. This CL changed #history-item-container's bottom border to be 1px only and let collapse section to have a 1px border, so that no matter the collapse section is opened or closed, the overall synced device card will always have a 2px bottom border. BUG=620162 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lshang@chromium.org changed reviewers: + tsergeant@chromium.org
PTAL thanks!
tsergeant@chromium.org changed reviewers: + calamity@chromium.org
Ah, this is a nifty solution that still looks good during the animation. lgtm, but +calamity to take a look.
lgtm
The CQ bit was checked by lshang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lshang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MD History: Fix bottom shadow of synced device card when collapsed Currently for synced device cards, the #history-item-container has a 2px bottom border, .card-title has a 1px bottom border and the collapse section has no borders. In this way, the overall synced device card will have a 2px border at bottom when opened, but will result in a 3px bottom border when the collapse section is closed, which is too thick. This CL changed #history-item-container's bottom border to be 1px only and let collapse section to have a 1px border, so that no matter the collapse section is opened or closed, the overall synced device card will always have a 2px bottom border. BUG=620162 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Fix bottom shadow of synced device card when collapsed Currently for synced device cards, the #history-item-container has a 2px bottom border, .card-title has a 1px bottom border and the collapse section has no borders. In this way, the overall synced device card will have a 2px border at bottom when opened, but will result in a 3px bottom border when the collapse section is closed, which is too thick. This CL changed #history-item-container's bottom border to be 1px only and let collapse section to have a 1px border, so that no matter the collapse section is opened or closed, the overall synced device card will always have a 2px bottom border. BUG=620162 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MD History: Fix bottom shadow of synced device card when collapsed Currently for synced device cards, the #history-item-container has a 2px bottom border, .card-title has a 1px bottom border and the collapse section has no borders. In this way, the overall synced device card will have a 2px border at bottom when opened, but will result in a 3px bottom border when the collapse section is closed, which is too thick. This CL changed #history-item-container's bottom border to be 1px only and let collapse section to have a 1px border, so that no matter the collapse section is opened or closed, the overall synced device card will always have a 2px bottom border. BUG=620162 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Fix bottom shadow of synced device card when collapsed Currently for synced device cards, the #history-item-container has a 2px bottom border, .card-title has a 1px bottom border and the collapse section has no borders. In this way, the overall synced device card will have a 2px border at bottom when opened, but will result in a 3px bottom border when the collapse section is closed, which is too thick. This CL changed #history-item-container's bottom border to be 1px only and let collapse section to have a 1px border, so that no matter the collapse section is opened or closed, the overall synced device card will always have a 2px bottom border. BUG=620162 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/34b990b50b984c81eb660e8ceaf9c2d431c7aad6 Cr-Commit-Position: refs/heads/master@{#407429} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/34b990b50b984c81eb660e8ceaf9c2d431c7aad6 Cr-Commit-Position: refs/heads/master@{#407429} |