Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2172143002: MD History: Fix bottom shadow of synced device card when collapsed (Closed)

Created:
4 years, 5 months ago by lshang
Modified:
4 years, 5 months ago
Reviewers:
tsergeant, calamity
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix bottom shadow of synced device card when collapsed Currently for synced device cards, the #history-item-container has a 2px bottom border, .card-title has a 1px bottom border and the collapse section has no borders. In this way, the overall synced device card will have a 2px border at bottom when opened, but will result in a 3px bottom border when the collapse section is closed, which is too thick. This CL changed #history-item-container's bottom border to be 1px only and let collapse section to have a 1px border, so that no matter the collapse section is opened or closed, the overall synced device card will always have a 2px bottom border. BUG=620162 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/34b990b50b984c81eb660e8ceaf9c2d431c7aad6 Cr-Commit-Position: refs/heads/master@{#407429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/md_history/synced_device_card.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
lshang
PTAL thanks!
4 years, 5 months ago (2016-07-22 06:20:23 UTC) #5
tsergeant
Ah, this is a nifty solution that still looks good during the animation. lgtm, but ...
4 years, 5 months ago (2016-07-25 03:57:48 UTC) #7
calamity
lgtm
4 years, 5 months ago (2016-07-25 04:40:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172143002/1
4 years, 5 months ago (2016-07-25 08:07:12 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 08:10:23 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 08:11:43 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34b990b50b984c81eb660e8ceaf9c2d431c7aad6
Cr-Commit-Position: refs/heads/master@{#407429}

Powered by Google App Engine
This is Rietveld 408576698