Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2172123003: Add ScopedNSAutoreleasePool to SchedulerWorker's Main Loop (Closed)

Created:
4 years, 5 months ago by robliao
Modified:
4 years, 5 months ago
Reviewers:
gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScopedNSAutoreleasePool to SchedulerWorker's Main Loop This provides autorelease support for Mac tasks. BUG=553459 Committed: https://crrev.com/4d8e12dfcba44dd61352161c80825719108021a8 Cr-Commit-Position: refs/heads/master@{#407267}

Patch Set 1 #

Patch Set 2 : Rebase to 54b95be #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M base/task_scheduler/scheduler_worker.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
robliao
4 years, 5 months ago (2016-07-22 18:36:22 UTC) #2
gab
lgtm
4 years, 5 months ago (2016-07-22 20:02:20 UTC) #9
fdoray
lgtm
4 years, 5 months ago (2016-07-22 20:29:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172123003/20001
4 years, 5 months ago (2016-07-22 21:27:23 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 21:33:56 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 21:35:59 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d8e12dfcba44dd61352161c80825719108021a8
Cr-Commit-Position: refs/heads/master@{#407267}

Powered by Google App Engine
This is Rietveld 408576698