Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Side by Side Diff: src/x64/macro-assembler-x64.h

Issue 21721002: Make some constants' meaning clear for X64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed danno's comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/deoptimizer-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 819 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 void Jump(Handle<Code> code_object, RelocInfo::Mode rmode); 830 void Jump(Handle<Code> code_object, RelocInfo::Mode rmode);
831 831
832 void Call(Address destination, RelocInfo::Mode rmode); 832 void Call(Address destination, RelocInfo::Mode rmode);
833 void Call(ExternalReference ext); 833 void Call(ExternalReference ext);
834 void Call(Handle<Code> code_object, 834 void Call(Handle<Code> code_object,
835 RelocInfo::Mode rmode, 835 RelocInfo::Mode rmode,
836 TypeFeedbackId ast_id = TypeFeedbackId::None()); 836 TypeFeedbackId ast_id = TypeFeedbackId::None());
837 837
838 // The size of the code generated for different call instructions. 838 // The size of the code generated for different call instructions.
839 int CallSize(Address destination, RelocInfo::Mode rmode) { 839 int CallSize(Address destination, RelocInfo::Mode rmode) {
840 return kCallInstructionLength; 840 return kCallSequenceLength;
841 } 841 }
842 int CallSize(ExternalReference ext); 842 int CallSize(ExternalReference ext);
843 int CallSize(Handle<Code> code_object) { 843 int CallSize(Handle<Code> code_object) {
844 // Code calls use 32-bit relative addressing. 844 // Code calls use 32-bit relative addressing.
845 return kShortCallInstructionLength; 845 return kShortCallInstructionLength;
846 } 846 }
847 int CallSize(Register target) { 847 int CallSize(Register target) {
848 // Opcode: REX_opt FF /2 m64 848 // Opcode: REX_opt FF /2 m64
849 return (target.high_bit() != 0) ? 3 : 2; 849 return (target.high_bit() != 0) ? 3 : 2;
850 } 850 }
(...skipping 688 matching lines...) Expand 10 before | Expand all | Expand 10 after
1539 masm->popfq(); \ 1539 masm->popfq(); \
1540 } \ 1540 } \
1541 masm-> 1541 masm->
1542 #else 1542 #else
1543 #define ACCESS_MASM(masm) masm-> 1543 #define ACCESS_MASM(masm) masm->
1544 #endif 1544 #endif
1545 1545
1546 } } // namespace v8::internal 1546 } } // namespace v8::internal
1547 1547
1548 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_ 1548 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « src/x64/deoptimizer-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698