Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/x64/debug-x64.cc

Issue 21721002: Make some constants' meaning clear for X64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed danno's comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 30 matching lines...) Expand all
41 41
42 bool BreakLocationIterator::IsDebugBreakAtReturn() { 42 bool BreakLocationIterator::IsDebugBreakAtReturn() {
43 return Debug::IsDebugBreakAtReturn(rinfo()); 43 return Debug::IsDebugBreakAtReturn(rinfo());
44 } 44 }
45 45
46 46
47 // Patch the JS frame exit code with a debug break call. See 47 // Patch the JS frame exit code with a debug break call. See
48 // CodeGenerator::VisitReturnStatement and VirtualFrame::Exit in codegen-x64.cc 48 // CodeGenerator::VisitReturnStatement and VirtualFrame::Exit in codegen-x64.cc
49 // for the precise return instructions sequence. 49 // for the precise return instructions sequence.
50 void BreakLocationIterator::SetDebugBreakAtReturn() { 50 void BreakLocationIterator::SetDebugBreakAtReturn() {
51 ASSERT(Assembler::kJSReturnSequenceLength >= 51 ASSERT(Assembler::kJSReturnSequenceLength >= Assembler::kCallSequenceLength);
52 Assembler::kCallInstructionLength);
53 rinfo()->PatchCodeWithCall( 52 rinfo()->PatchCodeWithCall(
54 Isolate::Current()->debug()->debug_break_return()->entry(), 53 Isolate::Current()->debug()->debug_break_return()->entry(),
55 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength); 54 Assembler::kJSReturnSequenceLength - Assembler::kCallSequenceLength);
56 } 55 }
57 56
58 57
59 // Restore the JS frame exit code. 58 // Restore the JS frame exit code.
60 void BreakLocationIterator::ClearDebugBreakAtReturn() { 59 void BreakLocationIterator::ClearDebugBreakAtReturn() {
61 rinfo()->PatchCode(original_rinfo()->pc(), 60 rinfo()->PatchCode(original_rinfo()->pc(),
62 Assembler::kJSReturnSequenceLength); 61 Assembler::kJSReturnSequenceLength);
63 } 62 }
64 63
65 64
66 // A debug break in the frame exit code is identified by the JS frame exit code 65 // A debug break in the frame exit code is identified by the JS frame exit code
67 // having been patched with a call instruction. 66 // having been patched with a call instruction.
68 bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo* rinfo) { 67 bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo* rinfo) {
69 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode())); 68 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode()));
70 return rinfo->IsPatchedReturnSequence(); 69 return rinfo->IsPatchedReturnSequence();
71 } 70 }
72 71
73 72
74 bool BreakLocationIterator::IsDebugBreakAtSlot() { 73 bool BreakLocationIterator::IsDebugBreakAtSlot() {
75 ASSERT(IsDebugBreakSlot()); 74 ASSERT(IsDebugBreakSlot());
76 // Check whether the debug break slot instructions have been patched. 75 // Check whether the debug break slot instructions have been patched.
77 return !Assembler::IsNop(rinfo()->pc()); 76 return !Assembler::IsNop(rinfo()->pc());
78 } 77 }
79 78
80 79
81 void BreakLocationIterator::SetDebugBreakAtSlot() { 80 void BreakLocationIterator::SetDebugBreakAtSlot() {
82 ASSERT(IsDebugBreakSlot()); 81 ASSERT(IsDebugBreakSlot());
83 rinfo()->PatchCodeWithCall( 82 rinfo()->PatchCodeWithCall(
84 Isolate::Current()->debug()->debug_break_slot()->entry(), 83 Isolate::Current()->debug()->debug_break_slot()->entry(),
85 Assembler::kDebugBreakSlotLength - Assembler::kCallInstructionLength); 84 Assembler::kDebugBreakSlotLength - Assembler::kCallSequenceLength);
86 } 85 }
87 86
88 87
89 void BreakLocationIterator::ClearDebugBreakAtSlot() { 88 void BreakLocationIterator::ClearDebugBreakAtSlot() {
90 ASSERT(IsDebugBreakSlot()); 89 ASSERT(IsDebugBreakSlot());
91 rinfo()->PatchCode(original_rinfo()->pc(), Assembler::kDebugBreakSlotLength); 90 rinfo()->PatchCode(original_rinfo()->pc(), Assembler::kDebugBreakSlotLength);
92 } 91 }
93 92
94 const bool Debug::FramePaddingLayout::kIsSupported = true; 93 const bool Debug::FramePaddingLayout::kIsSupported = true;
95 94
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 353
355 const bool Debug::kFrameDropperSupported = true; 354 const bool Debug::kFrameDropperSupported = true;
356 355
357 #undef __ 356 #undef __
358 357
359 #endif // ENABLE_DEBUGGER_SUPPORT 358 #endif // ENABLE_DEBUGGER_SUPPORT
360 359
361 } } // namespace v8::internal 360 } } // namespace v8::internal
362 361
363 #endif // V8_TARGET_ARCH_X64 362 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698