Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Side by Side Diff: src/x64/assembler-x64-inl.h

Issue 21721002: Make some constants' meaning clear for X64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed danno's comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/assembler-x64.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 // TODO(1550) We are passing NULL as a slot because cell can never be on 366 // TODO(1550) We are passing NULL as a slot because cell can never be on
367 // evacuation candidate. 367 // evacuation candidate.
368 host()->GetHeap()->incremental_marking()->RecordWrite( 368 host()->GetHeap()->incremental_marking()->RecordWrite(
369 host(), NULL, cell); 369 host(), NULL, cell);
370 } 370 }
371 } 371 }
372 372
373 373
374 bool RelocInfo::IsPatchedReturnSequence() { 374 bool RelocInfo::IsPatchedReturnSequence() {
375 // The recognized call sequence is: 375 // The recognized call sequence is:
376 // movq(kScratchRegister, immediate64); call(kScratchRegister); 376 // movq(kScratchRegister, address); call(kScratchRegister);
377 // It only needs to be distinguished from a return sequence 377 // It only needs to be distinguished from a return sequence
378 // movq(rsp, rbp); pop(rbp); ret(n); int3 *6 378 // movq(rsp, rbp); pop(rbp); ret(n); int3 *6
379 // The 11th byte is int3 (0xCC) in the return sequence and 379 // The 11th byte is int3 (0xCC) in the return sequence and
380 // REX.WB (0x48+register bit) for the call sequence. 380 // REX.WB (0x48+register bit) for the call sequence.
381 #ifdef ENABLE_DEBUGGER_SUPPORT 381 #ifdef ENABLE_DEBUGGER_SUPPORT
382 return pc_[2 + kPointerSize] != 0xCC; 382 return pc_[Assembler::kMoveAddressIntoScratchRegisterInstructionLength] !=
383 0xCC;
383 #else 384 #else
384 return false; 385 return false;
385 #endif 386 #endif
386 } 387 }
387 388
388 389
389 bool RelocInfo::IsPatchedDebugBreakSlotSequence() { 390 bool RelocInfo::IsPatchedDebugBreakSlotSequence() {
390 return !Assembler::IsNop(pc()); 391 return !Assembler::IsNop(pc());
391 } 392 }
392 393
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 ASSERT(len_ == 1 || len_ == 2); 540 ASSERT(len_ == 1 || len_ == 2);
540 int32_t* p = reinterpret_cast<int32_t*>(&buf_[len_]); 541 int32_t* p = reinterpret_cast<int32_t*>(&buf_[len_]);
541 *p = disp; 542 *p = disp;
542 len_ += sizeof(int32_t); 543 len_ += sizeof(int32_t);
543 } 544 }
544 545
545 546
546 } } // namespace v8::internal 547 } } // namespace v8::internal
547 548
548 #endif // V8_X64_ASSEMBLER_X64_INL_H_ 549 #endif // V8_X64_ASSEMBLER_X64_INL_H_
OLDNEW
« no previous file with comments | « src/x64/assembler-x64.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698