Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2172093002: X87: Reland of [builtins] Introduce a builtin for Abort(). (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland of [builtins] Introduce a builtin for Abort(). port 66cb026f4a54987bb4dc9e1d4734086571b872e0 (r37929) original commit message: Original message: Calling Runtime::kAbort through a builtin instead of the c-entry stub will allow to generate the call in a background thread, because a builtin provides its own handle, whereas a code stub does not. @v8-mips-ports: Could you take a special look at the padding that is done in MacroAssembler::Abort()? Reason for revert: The reason for reverting is: Blocks roll: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/1622 The problem was that on arm64 the builtin for Abort() contained a call to Abort(). The problem is fixed by using a NoUseRealAbortsScope in the code generation of Abort(). BUG= Committed: https://crrev.com/277838b1f0801cffb22620b3347eda027fdc43bd Cr-Commit-Position: refs/heads/master@{#37962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/builtins/x87/builtins-x87.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-22 02:02:36 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-22 02:16:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172093002/1
4 years, 5 months ago (2016-07-22 02:18:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 02:41:00 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 02:43:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/277838b1f0801cffb22620b3347eda027fdc43bd
Cr-Commit-Position: refs/heads/master@{#37962}

Powered by Google App Engine
This is Rietveld 408576698