Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2172083002: Do not discard screen info in RenderViewImpl::OnDisableAutoResize. (Closed)

Created:
4 years, 5 months ago by jbroman
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not discard screen info in RenderViewImpl::OnDisableAutoResize. This caused fast/autoresize/turn-off-autoresize.html to change the screen size to 0x0, which persisted to later tests. When a subsequent test attempted to resize the window, it was clamped to the 0x0 screen size, causing (flaky) failures. Committed: https://crrev.com/5ff10302aeb397b9e6c22c39aa73e15dc5b69a91 Cr-Commit-Position: refs/heads/master@{#407031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jbroman
Other places that construct ResizeParams in RenderWidget and RenderViewImpl do copy this field over. Failing ...
4 years, 5 months ago (2016-07-22 01:53:47 UTC) #4
piman
lgtm
4 years, 5 months ago (2016-07-22 02:04:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172083002/1
4 years, 5 months ago (2016-07-22 02:11:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:36:52 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:38:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ff10302aeb397b9e6c22c39aa73e15dc5b69a91
Cr-Commit-Position: refs/heads/master@{#407031}

Powered by Google App Engine
This is Rietveld 408576698