Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2172033002: Reland of Shrink gn's chrome.dll - now smaller than gyp's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweaked split counts to avoid breakage Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/gpu/ipc/service/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 22eca26536bb117a79c111c6cd2abf75d76a0d65..70c7179de57469f3c449a2ef7ced437b2daf540b 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -5,6 +5,7 @@
import("//build/config/chrome_build.gni")
import("//build/config/chromecast_build.gni")
import("//build/config/ui.gni")
+import("//build/split_static_library.gni")
import("//third_party/WebKit/Source/bindings/bindings.gni")
import("//third_party/WebKit/Source/bindings/core/v8/generated.gni")
import("//third_party/WebKit/Source/bindings/modules/modules.gni")
@@ -69,6 +70,20 @@ config("core_include_dirs") {
}
}
+if (is_component_build) {
+ link_target_type = "source_set"
+} else {
+ link_target_type = "split_static_library"
+
+ if (is_win && is_official_build) {
+ # Shard this target into parts to work around linker limitations
+ # on link time code generation builds.
+ split_count = 5
+ } else {
+ split_count = 1
+ }
+}
+
# GYP version: WebKit/Source/core/core.gyp:webcore_generated
source_set("generated") {
deps = [
@@ -188,7 +203,7 @@ component("core") {
}
# GYP version: //third_party/WebKit/Source/core/core.gyp:webcore_dom
-source_set("dom") {
+target(link_target_type, "dom") {
sources = rebase_path(webcore_dom_files, ".", "//")
configs -= core_config_remove
@@ -203,7 +218,7 @@ source_set("dom") {
}
# GYP version: //third_party/WebKit/Source/core/core.gyp:webcore_html
-source_set("html") {
+target(link_target_type, "html") {
sources = rebase_path(webcore_html_files, ".", "//")
configs -= core_config_remove
@@ -215,7 +230,7 @@ source_set("html") {
}
# GYP version: //third_party/WebKit/Source/core/core.gyp:webcore_svg
-source_set("svg") {
+target(link_target_type, "svg") {
sources = rebase_path(webcore_svg_files, ".", "//")
configs -= core_config_remove
@@ -227,7 +242,13 @@ source_set("svg") {
}
# GYP version: //third_party/WebKit/Source/core/core.gyp:webcore_remaining
-source_set("remaining") {
+target(link_target_type, "remaining") {
+ if (is_win && is_official_build) {
+ # Shard this target into parts to work around linker limitations
+ # on link time code generation builds.
+ split_count = 19
+ }
+
# This is currently a mashup of "webcore_rendering" and "webcore_remaining"
# in GYP. The file list variable is the same and then GYP filters on wether
# the path starts with "rendering/" or not. We should tweak the .gypis a bit
@@ -336,7 +357,7 @@ source_set("testing") {
}
# GYP version: //third_party/WebKit/Source/core/core.gyp:webcore_generated
-source_set("core_generated") {
+target(link_target_type, "core_generated") {
sources = bindings_core_v8_files
# These files include all the .cpp files generated from the .idl files
« no previous file with comments | « media/gpu/ipc/service/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698