Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: sync/protocol/synced_notification_app_info_specifics.proto

Issue 217203003: Update to latest protobufs to match the server side. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated protobufs: Fix unit tests, add missing fields. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/synced_notification_app_info_specifics.proto
diff --git a/sync/protocol/synced_notification_app_info_specifics.proto b/sync/protocol/synced_notification_app_info_specifics.proto
index 22bb4d259d06741986d17eb24753b7f37953c476..09726ff375fe576b3862e0201110f430e0fec03a 100644
--- a/sync/protocol/synced_notification_app_info_specifics.proto
+++ b/sync/protocol/synced_notification_app_info_specifics.proto
@@ -21,14 +21,36 @@ message SyncedNotificationAppInfoSpecifics {
}
message SyncedNotificationAppInfo {
- // The application ID of a subservice within the notification sending service.
+ // The application ID (the subservice within the sending service).
repeated string app_id = 1;
// The name to use in the settings screen for this app.
- optional string settings_display_name = 2;
+ // Use app_name field instead.
+ optional string settings_display_name = 2 [deprecated = true];
- // The icon to use. The URL of the icon may point to a
- // hi-res image, so clients should always size the image to the
- // preferred width and height specified in the Image proto.
- optional SyncedNotificationImage icon = 3;
+ // This field is deprecated. Use the app_icon field instead.
+ optional SyncedNotificationImage icon = 3 [deprecated = true];
+
+ optional string app_name = 4;
+
+ optional string settings_url = 5;
+
+ optional string info_url = 6;
+
+ message Icon {
+ enum Type {
+ GRAYSCALE_FAVICON_1X = 1; // Grayscale 16x16 px icon.
+ GRAYSCALE_FAVICON_2X = 2; // Grayscale 32x32 px icon.
+ COLOR_FAVICON_1X = 3; // Color 16x16 px icon.
+ COLOR_FAVICON_2X = 4; // Color 32x32 px icon.
+ COLOR_APPICON_1X = 5; // Color 80x80 px icon.
+ COLOR_APPICON_2X = 6; // Color 160x160 px icon.
+ };
+ optional Type type = 1;
+
+ optional string url = 2;
+ };
+
+ // A repeated set of icons of different resolutions and types.
+ repeated Icon app_icon = 7;
}
« no previous file with comments | « chrome/browser/notifications/sync_notifier/synced_notification.cc ('k') | sync/protocol/synced_notification_data.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698