Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 217203003: Update to latest protobufs to match the server side. (Closed)

Created:
6 years, 8 months ago by Pete Williamson
Modified:
6 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Update to latest protobufs to match the server side. To unlock features with seen/unseen state, hidpi screens, and locale awareness, update to the latest version of the protobuf used by the server side. BUG=305901 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261499

Patch Set 1 #

Patch Set 2 : Update protobufs: Add render context protobufs #

Patch Set 3 : Updated protobufs: Fix unit tests, add missing fields. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -12 lines) Patch
M chrome/browser/notifications/sync_notifier/sync_notifier_test_utils.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/sync_notifier/synced_notification.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/protocol/synced_notification_app_info_specifics.proto View 1 chunk +28 lines, -6 lines 0 comments Download
M sync/protocol/synced_notification_data.proto View 1 2 2 chunks +79 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Pete Williamson
6 years, 8 months ago (2014-04-01 18:20:12 UTC) #1
Pete Williamson
Added protobufs for the render context and app list.
6 years, 8 months ago (2014-04-02 18:11:56 UTC) #2
Nicolas Zea
lgtm
6 years, 8 months ago (2014-04-02 18:13:31 UTC) #3
Pete Williamson
6 years, 8 months ago (2014-04-02 21:50:30 UTC) #4
dewittj
On 2014/04/02 21:50:30, Pete Williamson wrote: fyi, compile of chrome and unit_tests succeeds, and the ...
6 years, 8 months ago (2014-04-02 22:09:54 UTC) #5
Pete Williamson
The CQ bit was checked by petewil@chromium.org
6 years, 8 months ago (2014-04-02 22:16:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petewil@chromium.org/217203003/30001
6 years, 8 months ago (2014-04-02 22:18:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:05:09 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:05:10 UTC) #9
Pete Williamson
The CQ bit was checked by petewil@chromium.org
6 years, 8 months ago (2014-04-03 16:22:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petewil@chromium.org/217203003/30001
6 years, 8 months ago (2014-04-03 16:23:30 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 19:12:43 UTC) #12
Message was sent while issue was closed.
Change committed as 261499

Powered by Google App Engine
This is Rietveld 408576698