Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: components/new_or_sad_tab_strings.grdp

Issue 2172013002: Wire up OOM exception to the sad tab page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@memory2
Patch Set: namespace Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/new_or_sad_tab_strings.grdp
diff --git a/components/new_or_sad_tab_strings.grdp b/components/new_or_sad_tab_strings.grdp
index e756c8610b068a185e6d48b3c3ab1ab757ce9745..b04b83d57f9a493c289935723f758d58f9c1e211 100644
--- a/components/new_or_sad_tab_strings.grdp
+++ b/components/new_or_sad_tab_strings.grdp
@@ -12,6 +12,16 @@
<message name="IDS_SAD_TAB_MESSAGE" desc="The message displayed on the sad tab page." formatter_data="android_java">
Something went wrong while displaying this webpage.
</message>
+ <if expr="_google_chrome">
+ <message name="IDS_SAD_TAB_OOM_MESSAGE" desc="The message displayed on the sad tab page if the tab died due to being out of memory." formatter_data="android_java">
+ Google Chrome ran out of memory while trying to display this webpage.
msw 2016/07/22 22:48:10 optional nit: use IDS_SHORT_PRODUCT_NAME?
Will Harris 2016/07/22 23:23:56 I found all the other .grdp were doing it this way
+ </message>
+ </if>
+ <if expr="not _google_chrome">
+ <message name="IDS_SAD_TAB_OOM_MESSAGE" desc="The message displayed on the sad tab page if the tab died due to being out of memory." formatter_data="android_java">
+ Chromium ran out of memory while trying to display this webpage.
+ </message>
+ </if>
<message name="IDS_SAD_TAB_HELP_MESSAGE" desc="The help message displayed on the sad tab page, with IDS_SAD_TAB_HELP_LINK embedded as a link to help.">
If you're seeing this frequently, try these <ph name="HELP_LINK">$1<ex>suggestions</ex></ph>.
</message>
« chrome/browser/ui/sad_tab_types.h ('K') | « chrome/browser/ui/views/sad_tab_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698