Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2172013002: Wire up OOM exception to the sad tab page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@memory2
Patch Set: increment outside macro Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_guest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ca096ba7e740a748cd70b7e244e51facbb1ee469..6f38cb9729e91393eb13fc7a2497e380434721d4 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -59103,7 +59103,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Tabs.SadTab.CrashCreated">
+<histogram name="Tabs.SadTab.CrashCreated" units="tabs">
<owner>jamescook@chromium.org</owner>
<summary>
Cumulative number of times a tab crashed with &quot;Aw, Snap!&quot;,
@@ -59115,7 +59115,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Tabs.SadTab.CrashDisplayed">
+<histogram name="Tabs.SadTab.CrashDisplayed" units="tabs">
<owner>jamescook@chromium.org</owner>
<summary>
Cumulative number of times a tab crashed with &quot;Aw, Snap!&quot; and the
@@ -59126,7 +59126,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Tabs.SadTab.KillCreated">
+<histogram name="Tabs.SadTab.KillCreated" units="tabs">
<owner>jamescook@chromium.org</owner>
<summary>
Cumulative number of times a tab was killed with a &quot;He's dead,
@@ -59140,7 +59140,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Tabs.SadTab.KillCreated.OOM">
+<histogram name="Tabs.SadTab.KillCreated.OOM" units="tabs">
<owner>oshima@chromium.org</owner>
<summary>
Cumulative number of times a tab was killed with a &quot;He's dead,
@@ -59153,7 +59153,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Tabs.SadTab.KillDisplayed">
+<histogram name="Tabs.SadTab.KillDisplayed" units="tabs">
<owner>jamescook@chromium.org</owner>
<summary>
Cumulative number of times a tab was killed with a &quot;He's dead,
@@ -59164,7 +59164,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Tabs.SadTab.KillDisplayed.OOM">
+<histogram name="Tabs.SadTab.KillDisplayed.OOM" units="tabs">
<owner>oshima@chromium.org</owner>
<summary>
Cumulative number of times a tab was killed with a &quot;He's dead,
@@ -59176,7 +59176,30 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Tabs.SadTab.ReloadCount">
+<histogram name="Tabs.SadTab.OomCreated" units="tabs">
+ <owner>wfh@chromium.org</owner>
+ <summary>
+ Cumulative number of times a tab crashed with &quot;Aw, Snap!&quot;,
+ recorded once per tab oom event. For example, a user who ran out of memory
+ in 3 tabs will record a count in the 1 bin, 2 bin, and 3 bin. Thus each bin
+ N is the number of sessions where users experienced N or more oom events.
+ The user may not have actually seen the sad tab page, as it might have been
+ an inactive tab. Compare to Tabs.SadTab.OomDisplayed.
+ </summary>
+</histogram>
+
+<histogram name="Tabs.SadTab.OomDisplayed" units="tabs">
+ <owner>wfh@chromium.org</owner>
+ <summary>
+ Cumulative number of times a tab ran out of memory with &quot;Aw,
+ Snap!&quot; and the user saw the page, recorded once per tab oom event. For
+ example, a user who ran out of memory in 3 tabs will record a count in the 1
+ bin, 2 bin, and 3 bin. Thus each bin N is the number of sessions where
+ users experienced N or more oom events. Compare to Tabs.SadTab.OomCreated.
+ </summary>
+</histogram>
+
+<histogram name="Tabs.SadTab.ReloadCount" units="tabs">
<owner>jamescook@chromium.org</owner>
<summary>
The number of times a tab was reloaded because it was killed (usually by the
« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_guest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698