Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3180)

Unified Diff: ash/accelerators/accelerator_delegate.h

Issue 2171983002: Move processing out of AcceleratorDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wire_up_controller
Patch Set: not relative Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/accelerators/accelerator_delegate.h
diff --git a/ash/accelerators/accelerator_delegate.h b/ash/accelerators/accelerator_delegate.h
index 0614f873d9d8392c2ec9389c666d10cfbd8be0f8..18775a4a55480bbe178fd2a93635df6f564d6b18 100644
--- a/ash/accelerators/accelerator_delegate.h
+++ b/ash/accelerators/accelerator_delegate.h
@@ -5,6 +5,8 @@
#ifndef ASH_ACCELERATORS_ACCELERATOR_DELEGATE_H_
#define ASH_ACCELERATORS_ACCELERATOR_DELEGATE_H_
+#include <memory>
+
#include "ash/ash_export.h"
#include "base/compiler_specific.h"
James Cook 2016/07/22 16:48:02 nit: remove while you're here
sky 2016/07/22 17:05:06 That one is needed because of NON_EXPORTED_BASE.
#include "base/macros.h"
@@ -12,6 +14,8 @@
namespace ash {
+class AcceleratorRouter;
+
class ASH_EXPORT AcceleratorDelegate
: NON_EXPORTED_BASE(public ::wm::AcceleratorDelegate) {
public:
@@ -23,12 +27,7 @@ class ASH_EXPORT AcceleratorDelegate
const ui::Accelerator& accelerator) override;
private:
- // Returns true if the window should be allowed a chance to handle
- // system keys.
- bool CanConsumeSystemKeys(const ui::KeyEvent& event);
-
- bool ShouldProcessAcceleratorNow(const ui::KeyEvent& event,
- const ui::Accelerator& accelerator);
+ std::unique_ptr<AcceleratorRouter> router_;
DISALLOW_COPY_AND_ASSIGN(AcceleratorDelegate);
};
« no previous file with comments | « no previous file | ash/accelerators/accelerator_delegate.cc » ('j') | ash/common/accelerators/accelerator_router.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698