Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2171973006:
[worklets] Change WorkerInspectorController to accept a WorkerThread. (Closed)
|
Created:
4 years, 5 months ago by ikilpatrick Modified:
4 years, 4 months ago CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@script-env Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[worklets] Change WorkerInspectorController to accept a WorkerThread.
This is to allow WorkerInspectorController to work with a ThreadedWorkletGlobalScope as well.
The alternative here is to add the required methods (thread() etc) on WorkerOrWorkletGlobalScope which I don't think is the best approach.
BUG=567358
Committed: https://crrev.com/0177e05c812a52e8554678bd33fc4c0397b8b9df
Cr-Commit-Position: refs/heads/master@{#408278}
Patch Set 1 #Patch Set 2 : [worklets] Change WorkerInspectorController to accept a WorkerThread. #Patch Set 3 : . #
Total comments: 10
Patch Set 4 : . #
Messages
Total messages: 24 (15 generated)
Description was changed from ========== [worklets] Change WorkerInspectorController to accept a WorkerThread. BUG= ========== to ========== [worklets] Change WorkerInspectorController to accept a WorkerThread. This is to allow WorkerInspectorController to work with a ThreadedWorkletGlobalScope as well. The alternative here is to add the required methods (thread() etc) on WorkerOrWorkletGlobalScope which I don't think is the best approach. BUG=567358 ==========
ikilpatrick@chromium.org changed reviewers: + kinuko@chromium.org, nhiroki@chromium.org, yhirano@chromium.org
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
My current WIP patch for the whole ThreadedWorklet* is here: https://codereview.chromium.org/2171973002#ps60001 Going to add stub classes for window.compositorWorklet then work on what thread messaging can be common.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dgozman@chromium.org changed reviewers: + dgozman@chromium.org
I think this approach is fine. https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp (right): https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp:71: m_logAgent = new InspectorLogAgent(m_thread->consoleMessageStorage()); Does this work?
lgtm https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp (right): https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp:37: #include "core/workers/WorkerGlobalScope.h" Maybe WorkerGlobalScope.h is not necessary. https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/WorkerInspectorController.h (right): https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.h:46: class WorkerGlobalScope; Can you remove this?
lgtm https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp (right): https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp:61: { DCHECK(!m_thread); https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/WorkerInspectorController.h (right): https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.h:60: ~WorkerInspectorController(); +override
lgtm after comments are addressed/resolved
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp (right): https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp:37: #include "core/workers/WorkerGlobalScope.h" On 2016/07/27 07:12:05, nhiroki wrote: > Maybe WorkerGlobalScope.h is not necessary. Done. https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp:61: { On 2016/07/27 08:57:06, yhirano wrote: > DCHECK(!m_thread); Done. https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp:71: m_logAgent = new InspectorLogAgent(m_thread->consoleMessageStorage()); On 2016/07/27 01:47:52, dgozman wrote: > Does this work? Yup, WorkerThread has a consoleMessageStorage method which sends to it's globalScope. https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/WorkerInspectorController.h (right): https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.h:46: class WorkerGlobalScope; On 2016/07/27 07:12:05, nhiroki wrote: > Can you remove this? Done. https://codereview.chromium.org/2171973006/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/WorkerInspectorController.h:60: ~WorkerInspectorController(); On 2016/07/27 08:57:06, yhirano wrote: > +override Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by ikilpatrick@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org, nhiroki@chromium.org, yhirano@chromium.org Link to the patchset: https://codereview.chromium.org/2171973006/#ps60001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [worklets] Change WorkerInspectorController to accept a WorkerThread. This is to allow WorkerInspectorController to work with a ThreadedWorkletGlobalScope as well. The alternative here is to add the required methods (thread() etc) on WorkerOrWorkletGlobalScope which I don't think is the best approach. BUG=567358 ========== to ========== [worklets] Change WorkerInspectorController to accept a WorkerThread. This is to allow WorkerInspectorController to work with a ThreadedWorkletGlobalScope as well. The alternative here is to add the required methods (thread() etc) on WorkerOrWorkletGlobalScope which I don't think is the best approach. BUG=567358 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [worklets] Change WorkerInspectorController to accept a WorkerThread. This is to allow WorkerInspectorController to work with a ThreadedWorkletGlobalScope as well. The alternative here is to add the required methods (thread() etc) on WorkerOrWorkletGlobalScope which I don't think is the best approach. BUG=567358 ========== to ========== [worklets] Change WorkerInspectorController to accept a WorkerThread. This is to allow WorkerInspectorController to work with a ThreadedWorkletGlobalScope as well. The alternative here is to add the required methods (thread() etc) on WorkerOrWorkletGlobalScope which I don't think is the best approach. BUG=567358 Committed: https://crrev.com/0177e05c812a52e8554678bd33fc4c0397b8b9df Cr-Commit-Position: refs/heads/master@{#408278} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0177e05c812a52e8554678bd33fc4c0397b8b9df Cr-Commit-Position: refs/heads/master@{#408278} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
