Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2171973003: Separates out accelerator handling in windowmanager (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separates out accelerator handling in windowmanager This will make it easy for different parts of the ash wm code to register accelerators. BUG=612331 TEST=none R=ben@chromium.org Committed: https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a Cr-Commit-Position: refs/heads/master@{#407216}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : git add #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -412 lines) Patch
M ash/mus/BUILD.gn View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
D ash/mus/accelerator_registrar_impl.h View 1 chunk +0 lines, -78 lines 0 comments Download
D ash/mus/accelerator_registrar_impl.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D ash/mus/accelerator_registrar_unittest.cc View 1 chunk +0 lines, -116 lines 0 comments Download
A ash/mus/accelerators/accelerator_handler.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A ash/mus/accelerators/accelerator_ids.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A + ash/mus/accelerators/accelerator_registrar_impl.h View 5 chunks +12 lines, -8 lines 0 comments Download
A + ash/mus/accelerators/accelerator_registrar_impl.cc View 1 7 chunks +20 lines, -16 lines 0 comments Download
A + ash/mus/accelerators/accelerator_registrar_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/mus/window_manager.h View 1 3 chunks +11 lines, -2 lines 0 comments Download
M ash/mus/window_manager.cc View 6 chunks +26 lines, -24 lines 0 comments Download
M ash/mus/window_manager_application.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M ash/mus/window_manager_observer.h View 1 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
sky
4 years, 5 months ago (2016-07-22 03:24:59 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 5 months ago (2016-07-22 03:36:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171973003/40001
4 years, 5 months ago (2016-07-22 16:17:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/40023) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-22 16:19:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171973003/60001
4 years, 5 months ago (2016-07-22 16:38:39 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-22 18:43:33 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 18:44:48 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/853669a14f2788e508597bf9e72235ff6d77945a
Cr-Commit-Position: refs/heads/master@{#407216}

Powered by Google App Engine
This is Rietveld 408576698