tools/metrics/histograms/histograms.xml - Issue 2171833002: Add some words of caution to File::Flush().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2171833002: Add some words of caution to File::Flush(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove PlatformFile.FlushTime histogram. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 56ecbb048820ec70db206c90e9b774b6e65071f8..c1b560b376a78ab9787fe9846be01d50042bf667 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -40918,11 +40918,6 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

-<histogram name="PlatformFile.FlushTime" units="ms">

- <owner>tnagel@chromium.org</owner>

- <summary>The time it takes to run File::Flush().</summary>

-</histogram>

Ilya Sherman 2016/07/22 17:21:34 Please mark this histogram as <obsolete> rather th

Thiemo Nagel 2016/07/22 17:45:45 Done.

Deprecated as of 2013-05, replaced by

« no previous file with comments | « base/files/file_win.cc ('k') | no next file » | no next file with comments »