Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1705)

Unified Diff: content/renderer/render_view_impl.cc

Issue 217183004: Migrate addMessageToConsole API to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase + fix the test_runner Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/shell/renderer/test_runner/WebFrameTestProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 4a3bd5b1d408d45bc2e8896b42fc6d657d205743..042b63e5bcce619363138a9073e85192d7843fb9 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1626,52 +1626,6 @@ WebStorageNamespace* RenderViewImpl::createSessionStorageNamespace() {
return new WebStorageNamespaceImpl(session_storage_namespace_id_);
}
-bool RenderViewImpl::shouldReportDetailedMessageForSource(
- const WebString& source) {
- return GetContentClient()->renderer()->ShouldReportDetailedMessageForSource(
- source);
-}
-
-void RenderViewImpl::didAddMessageToConsole(
- const WebConsoleMessage& message, const WebString& source_name,
- unsigned source_line, const WebString& stack_trace) {
- logging::LogSeverity log_severity = logging::LOG_VERBOSE;
- switch (message.level) {
- case WebConsoleMessage::LevelDebug:
- log_severity = logging::LOG_VERBOSE;
- break;
- case WebConsoleMessage::LevelLog:
- case WebConsoleMessage::LevelInfo:
- log_severity = logging::LOG_INFO;
- break;
- case WebConsoleMessage::LevelWarning:
- log_severity = logging::LOG_WARNING;
- break;
- case WebConsoleMessage::LevelError:
- log_severity = logging::LOG_ERROR;
- break;
- default:
- NOTREACHED();
- }
-
- if (shouldReportDetailedMessageForSource(source_name)) {
- FOR_EACH_OBSERVER(
- RenderViewObserver,
- observers_,
- DetailedConsoleMessageAdded(message.text,
- source_name,
- stack_trace,
- source_line,
- static_cast<int32>(log_severity)));
- }
-
- Send(new ViewHostMsg_AddMessageToConsole(routing_id_,
- static_cast<int32>(log_severity),
- message.text,
- static_cast<int32>(source_line),
- source_name));
-}
-
void RenderViewImpl::printPage(WebFrame* frame) {
FOR_EACH_OBSERVER(RenderViewObserver, observers_,
PrintPage(frame, handling_input_event_));
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/shell/renderer/test_runner/WebFrameTestProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698