Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 217183004: Migrate addMessageToConsole API to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase + fix the test_runner Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 7c8342b37ed80245abf6df3f998ed5746c91cdad..3abfd17c3fe0844062ab5550d51a62bace2bb435 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -15,6 +15,7 @@
#include "base/metrics/histogram.h"
#include "base/process/kill.h"
#include "base/process/process.h"
+#include "base/strings/string16.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "content/child/appcache/appcache_dispatcher.h"
@@ -1372,6 +1373,62 @@ void RenderFrameImpl::didMatchCSS(
frame, newly_matching_selectors, stopped_matching_selectors);
}
+bool RenderFrameImpl::shouldReportDetailedMessageForSource(
+ const blink::WebString& source) {
+ return GetContentClient()->renderer()->ShouldReportDetailedMessageForSource(
+ source);
+}
+
+void RenderFrameImpl::didAddMessageToConsole(
+ const blink::WebConsoleMessage& message,
+ const blink::WebString& source_name,
+ unsigned source_line,
+ const blink::WebString& stack_trace) {
+ logging::LogSeverity log_severity = logging::LOG_VERBOSE;
+ switch (message.level) {
+ case blink::WebConsoleMessage::LevelDebug:
+ log_severity = logging::LOG_VERBOSE;
+ break;
+ case blink::WebConsoleMessage::LevelLog:
+ case blink::WebConsoleMessage::LevelInfo:
+ log_severity = logging::LOG_INFO;
+ break;
+ case blink::WebConsoleMessage::LevelWarning:
+ log_severity = logging::LOG_WARNING;
+ break;
+ case blink::WebConsoleMessage::LevelError:
+ log_severity = logging::LOG_ERROR;
+ break;
+ default:
+ NOTREACHED();
+ }
+
+ if (shouldReportDetailedMessageForSource(source_name)) {
+ FOR_EACH_OBSERVER(
+ RenderViewObserver,
+ render_view_->observers(),
+ DetailedConsoleMessageAdded(message.text,
+ source_name,
+ stack_trace,
+ source_line,
+ static_cast<int32>(log_severity)));
+ FOR_EACH_OBSERVER(
+ RenderFrameObserver,
+ observers_,
+ DetailedConsoleMessageAdded(message.text,
+ source_name,
+ stack_trace,
+ source_line,
+ static_cast<int32>(log_severity)));
+ }
+
+ Send(new FrameHostMsg_AddMessageToConsole(routing_id_,
+ static_cast<int32>(log_severity),
+ message.text,
+ static_cast<int32>(source_line),
+ source_name));
+}
+
void RenderFrameImpl::loadURLExternally(blink::WebFrame* frame,
const blink::WebURLRequest& request,
blink::WebNavigationPolicy policy) {
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698