Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1568)

Unified Diff: content/public/renderer/render_frame_observer.h

Issue 217183004: Migrate addMessageToConsole API to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/render_frame_observer.h
diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h
index b197a98c77aa26de65e7341c320eaa5c2a771e1d..b938f441d52a66277544d75953d9f0b4fd53d0e6 100644
--- a/content/public/renderer/render_frame_observer.h
+++ b/content/public/renderer/render_frame_observer.h
@@ -7,6 +7,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "base/strings/string16.h"
#include "content/common/content_export.h"
#include "ipc/ipc_listener.h"
#include "ipc/ipc_sender.h"
@@ -48,6 +49,18 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,
int world_id) {}
virtual void DidClearWindowObject(int world_id) {}
+ // Called when we receive a console message from WebKit for which we requested
nasko 2014/03/28 23:05:05 nit: Blink
mkosiba (inactive) 2014/03/31 09:48:41 Done.
+ // extra details (like the stack trace). |message| is the error message,
+ // |source| is the WebKit-reported source of the error (either external or
nasko 2014/03/28 23:05:05 nit: Blink
mkosiba (inactive) 2014/03/31 09:48:41 Done.
+ // internal), and |stack_trace| is the stack trace of the error in a
+ // human-readable format (each frame is formatted as
+ // "\n at function_name (source:line_number:column_number)").
+ virtual void DetailedConsoleMessageAdded(const base::string16& message,
+ const base::string16& source,
+ const base::string16& stack_trace,
+ int32 line_number,
+ int32 severity_level) {}
+
// IPC::Listener implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698