Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

Issue 2171813004: mash: Fold ShelfItemDelegateManager into ShelfModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
index ba8cc6fb5ff196e45042a869a6122e38ec33a28b..464af02ef5f47c0429270b0d02674453f631bc68 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
@@ -8,7 +8,6 @@
#include <list>
#include <memory>
-#include "ash/common/shelf/shelf_item_delegate_manager.h"
#include "ash/common/shelf/shelf_model_observer.h"
#include "ash/common/shelf/shelf_types.h"
#include "ash/display/window_tree_host_manager.h"
@@ -65,7 +64,6 @@ class ChromeLauncherControllerImpl
private ash::WindowTreeHostManager::Observer,
private AppIconLoaderDelegate,
private AppSyncUIStateObserver,
- private ash::ShelfItemDelegateManagerObserver,
private app_list::AppListSyncableService::Observer {
public:
ChromeLauncherControllerImpl(Profile* profile, ash::ShelfModel* model);
@@ -185,11 +183,6 @@ class ChromeLauncherControllerImpl
std::vector<std::unique_ptr<AppIconLoader>>& loaders);
const std::string& GetAppIdFromShelfIdForTest(ash::ShelfID id);
- // Sets the ash::ShelfItemDelegateManager only for unittests and doesn't
- // take an ownership of it.
- void SetShelfItemDelegateManagerForTest(
- ash::ShelfItemDelegateManager* manager);
-
private:
friend class ChromeLauncherControllerImplTest;
friend class ShelfAppBrowserTest;
@@ -295,15 +288,13 @@ class ChromeLauncherControllerImpl
AppIconLoader* GetAppIconLoaderForApp(const std::string& app_id);
- // ash::ShelfItemDelegateManagerObserver:
- void OnSetShelfItemDelegate(ash::ShelfID id,
- ash::ShelfItemDelegate* item_delegate) override;
-
// ash::ShelfModelObserver:
void ShelfItemAdded(int index) override;
void ShelfItemRemoved(int index, ash::ShelfID id) override;
void ShelfItemMoved(int start_index, int target_index) override;
void ShelfItemChanged(int index, const ash::ShelfItem& old_item) override;
+ void OnSetShelfItemDelegate(ash::ShelfID id,
+ ash::ShelfItemDelegate* item_delegate) override;
// ash::WindowTreeHostManager::Observer:
void OnDisplayConfigurationChanged() override;
@@ -320,8 +311,6 @@ class ChromeLauncherControllerImpl
ash::ShelfModel* model_;
- ash::ShelfItemDelegateManager* item_delegate_manager_ = nullptr;
-
// Profile used for prefs and loading extensions. This is NOT necessarily the
// profile new windows are created with.
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698