Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: ash/common/shelf/shelf_model_observer.h

Issue 2171813004: mash: Fold ShelfItemDelegateManager into ShelfModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/shelf/shelf_model_observer.h
diff --git a/ash/common/shelf/shelf_model_observer.h b/ash/common/shelf/shelf_model_observer.h
index 7ef6764fd2fae326976f84edd129fc5a6f0e3368..794300da4900b36a740797c60d518d1021c3680a 100644
--- a/ash/common/shelf/shelf_model_observer.h
+++ b/ash/common/shelf/shelf_model_observer.h
@@ -11,6 +11,7 @@
namespace ash {
struct ShelfItem;
+class ShelfItemDelegate;
class ASH_EXPORT ShelfModelObserver {
public:
@@ -29,6 +30,13 @@ class ASH_EXPORT ShelfModelObserver {
// before the change.
virtual void ShelfItemChanged(int index, const ShelfItem& old_item) = 0;
+ // Gets called when a ShelfItemDelegate gets changed. Note that
+ // |item_delegate| can be null.
+ // NOTE: This is added a temporary fix for M39 to fix crbug.com/429870.
+ // TODO(skuhne): Find the real reason for this problem and remove this fix.
+ virtual void OnSetShelfItemDelegate(ShelfID id,
+ ShelfItemDelegate* item_delegate) = 0;
+
protected:
virtual ~ShelfModelObserver() {}
};

Powered by Google App Engine
This is Rietveld 408576698