chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc - Issue 2171813004: mash: Fold ShelfItemDelegateManager into ShelfModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Issue 2171813004: mash: Fold ShelfItemDelegateManager into ShelfModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: explicitly destroy ShelfItemDelegates Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc b/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

index 30612e09e78227ad588723819a66642855d39659..a2c2258d8d8d42b4422a3e3aaf6cb5b64a84c0f5 100644

--- a/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

@@ -55,7 +55,7 @@ class LauncherContextMenuTest : public ash::test::AshTestBase {

LauncherContextMenu* CreateLauncherContextMenu(

ash::ShelfItemType shelf_item_type) {

ash::ShelfItem item;

- item.id = 1; // dummy id

+ item.id = 123; // dummy id

item.type = shelf_item_type;

return LauncherContextMenu::Create(controller_.get(), &item, GetWmShelf());

}

« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_context_menu.cc ('k') | no next file » | no next file with comments »