Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Unified Diff: ash/shelf/shelf_view.h

Issue 2171813004: mash: Fold ShelfItemDelegateManager into ShelfModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: explicitly destroy ShelfItemDelegates Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_unittest.cc ('k') | ash/shelf/shelf_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_view.h
diff --git a/ash/shelf/shelf_view.h b/ash/shelf/shelf_view.h
index c57dc156ae5c5771501fe08676aaaf7bfeba17bd..0bbc33470c88040b827d5d3158aa884e1e42ed92 100644
--- a/ash/shelf/shelf_view.h
+++ b/ash/shelf/shelf_view.h
@@ -47,7 +47,6 @@ class Shelf;
class ShelfButton;
class ShelfDelegate;
class ShelfIconObserver;
-class ShelfItemDelegateManager;
class ShelfModel;
struct ShelfItem;
class WmShelf;
@@ -288,6 +287,8 @@ class ASH_EXPORT ShelfView : public views::View,
void ShelfItemRemoved(int model_index, ShelfID id) override;
void ShelfItemChanged(int model_index, const ShelfItem& old_item) override;
void ShelfItemMoved(int start_index, int target_index) override;
+ void OnSetShelfItemDelegate(ShelfID id,
+ ShelfItemDelegate* item_delegate) override;
// Overridden from InkDropButtonListener:
void ButtonPressed(views::Button* sender,
@@ -445,9 +446,6 @@ class ASH_EXPORT ShelfView : public views::View,
// The rip off view when a snap back operation is underway.
views::View* snap_back_from_rip_off_view_;
- // Holds ShelfItemDelegateManager.
- ShelfItemDelegateManager* item_manager_;
-
// True when this ShelfView is used for Overflow Bubble.
bool overflow_mode_;
« no previous file with comments | « ash/shelf/shelf_unittest.cc ('k') | ash/shelf/shelf_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698